Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync comment status #116

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Sync comment status #116

merged 2 commits into from
Aug 1, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jul 26, 2024

By default, Distributor does not sync the Comment and Ping statuses.

This PR makes both statuses be kept in sync for distributed posts.

Testing pushing

  • On site A, create a new post and leave comments and pings closed
  • Publish and distribute it to site B
  • On site B, confirm that the distributed post kept the closed comments and pings statuses
  • Back on site A, edit the site and change the comment status. Save
  • Go back to site B and confirm the change was synced

Testing pulling

  • On site A, create a new post and leave comments and pings closed
  • Publish
  • On site B, pull this post from site A
  • On site B, confirm that the distributed post kept the closed comments and pings statuses
  • Back on site A, edit the site and change the comment status. Save
  • Go back to site B and confirm the change was synced

@leogermani leogermani requested a review from a team as a code owner July 26, 2024 17:08
@leogermani leogermani self-assigned this Jul 26, 2024
@adekbadek adekbadek merged commit 5844853 into trunk Aug 1, 2024
4 checks passed
@adekbadek adekbadek deleted the feat/sync-comment-status branch August 1, 2024 10:37
matticbot pushed a commit that referenced this pull request Aug 1, 2024
# [1.11.0-alpha.1](v1.10.1...v1.11.0-alpha.1) (2024-08-01)

### Bug Fixes

* **memberships-sync:** handle active subs from other nodes ([#114](#114)) ([97f9a58](97f9a58))

### Features

* **distributor:** sync comment status ([#116](#116)) ([5844853](5844853))
* ensure that membership plans have unique network id ([#108](#108)) ([d2d63a0](d2d63a0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.11.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 13, 2024
# [2.0.0](v1.10.1...v2.0.0) (2024-08-13)

### Bug Fixes

* **memberships-sync:** handle active subs from other nodes ([#114](#114)) ([97f9a58](97f9a58))
* update dependencies to support `@wordpress/scripts` ([#104](#104)) ([e9691b8](e9691b8))

### Features

* **distributor:** sync comment status ([#116](#116)) ([5844853](5844853))
* ensure that membership plans have unique network id ([#108](#108)) ([d2d63a0](d2d63a0))

### BREAKING CHANGES

* Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version.

* chore: refactor for newspack-scripts dependency updates

* chore: update composer

* fix: peer dependencies

* chore: update newspack-scripts to v5.6.0-alpha.3

* chore: update newspack-scripts to v5.6.0-alpha.4

* chore: remove unnecessary prettier config file

* chore: update newspack-scripts to v5.6.0-alpha.7

* fix: update phpcs.xml

* chore: bump newspack-scripts to v5.5.2
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants