-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/network pass #40
Conversation
Thanks @adekbadek , I have fixed the link and changed the approach to block edition. I have now a check for the Also, this work surfaced a small issue with the plugin. The To be consistent, this method should not be called in such cases. Just as I slightly changed the architecture there and updated the docs. It should be good now. (btw, I'm open to revisiting the method names) |
# Conflicts: # includes/incoming-events/class-order-changed.php # includes/incoming-events/class-subscription-changed.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, pending some wording suggestions.
Co-authored-by: Adam Boro <aborowski24@gmail.com>
Co-authored-by: Adam Boro <aborowski24@gmail.com>
@adekbadek this is good to land. But leaving this un-merged to see how we want to proceed with the release, If we want to have this in an epic branch, a feature flag... or if it's fine since it will have no effect until a Network ID is set |
I think we're good to go, just remember to add public-facing docs after the release. |
🎉 This PR is included in version 1.3.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Creates the Network pass feature.
Also, this work surfaced a small issue with the plugin. The post_process_in_hub method was being called even for events that were triggered in the Hub itself. This would cause the local memberhips to get the post meta and they would become uneditable.
To be consistent, this method should not be called in such cases. Just as process_in_node is not called in node for their own events.
I slightly changed the architecture there and updated the docs. It should be good now.
** Testing
Setup
Now let's test the flow
newspack_network_woo_membership_updated
is triggered and added to the event log