Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display membership plans across the network #59

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Feb 20, 2024

All Submissions:

Changes proposed in this Pull Request:

Displays membership plans from the whole network:

image

How to test the changes in this Pull Request:

  1. On Hub and Node site, set up some membership plans and link some of them via the "Network ID" feature (Feat/network pass #40)
  2. Visit the "Membership Plans" view in the Hub, observe that all memberships across the network are listed there
  3. Make a change to the "Network ID" of a membership on a Node site, then click "Refetch Plans" on this view
  4. Click "Edit" links and verify they point to the correct views
  5. Observe the data has been updated accordingly

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Base automatically changed from feat/network-pass to trunk February 21, 2024 13:29
@adekbadek adekbadek marked this pull request as ready for review February 21, 2024 13:35
@adekbadek adekbadek requested a review from a team as a code owner February 21, 2024 13:35
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Working well.

One non-blocking comment is I'd name all classes and files you named as "Memberships" as "Membership_Plans"... This whole thing is confusing enough and I'd rather be very specific in the names there

@adekbadek
Copy link
Member Author

Yeah, good idea! Initially I thought there would be in that view than just membership plans, but with the current scope it's better to be specific.

@adekbadek adekbadek merged commit 6fa01fd into trunk Feb 22, 2024
3 checks passed
@adekbadek adekbadek deleted the feat/membership-plans-list branch February 22, 2024 08:54
@adekbadek adekbadek restored the feat/membership-plans-list branch February 22, 2024 09:27
matticbot pushed a commit that referenced this pull request Feb 23, 2024
# [1.3.0-alpha.1](v1.2.0...v1.3.0-alpha.1) (2024-02-23)

### Bug Fixes

* memberships sync ([#63](#63)) ([0a54f1d](0a54f1d))

### Features

* add hub bookmarks to nodes ([#56](#56)) ([54700a0](54700a0))
* add option to manually sync users  ([#53](#53)) ([3ec1b19](3ec1b19))
* display membership plans from the network ([#59](#59)) ([6fa01fd](6fa01fd))
* enhance network subscriptions and orders search ([#55](#55)) ([bcb0615](bcb0615))
* Node connection using a link ([#58](#58)) ([721f8b2](721f8b2))
* **wp-cli:** add command to backfill events ([#51](#51)) ([13d2498](13d2498))
* **wp-cli:** add process pending webhook requests command ([#67](#67)) ([7dbd8dc](7dbd8dc))
* **wp-cli:** sync all events from the Hub ([#65](#65)) ([dc595ca](dc595ca))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 28, 2024
# [1.3.0](v1.2.0...v1.3.0) (2024-02-28)

### Bug Fixes

* backfill duplicate handling; woo links in wp-admin-bar ([#71](#71), [#72](#72)) ([bbce13b](bbce13b))
* cli commands ([#73](#73)) ([ff563ac](ff563ac))
* memberships sync ([#63](#63)) ([0a54f1d](0a54f1d))
* missing woocommerce-memberships handling ([76dbdf7](76dbdf7))

### Features

* add hub bookmarks to nodes ([#56](#56)) ([54700a0](54700a0))
* add option to manually sync users  ([#53](#53)) ([3ec1b19](3ec1b19))
* display membership plans from the network ([#59](#59)) ([6fa01fd](6fa01fd))
* enhance network subscriptions and orders search ([#55](#55)) ([bcb0615](bcb0615))
* Node connection using a link ([#58](#58)) ([721f8b2](721f8b2))
* **wp-cli:** add command to backfill events ([#51](#51)) ([13d2498](13d2498))
* **wp-cli:** add process pending webhook requests command ([#67](#67)) ([7dbd8dc](7dbd8dc))
* **wp-cli:** sync all events from the Hub ([#65](#65)) ([dc595ca](dc595ca))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants