Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Right now, translations aren't being pulled into the Newspack Newsletter editor. While we dig into the cause of this odd issue, this PR moves three strings --
Continue reading...
, and theBy
andand
from the byline into a PHP file, so they can be swapped out.See: 1200550061930446-as-1205587112319820
How to test the changes in this Pull Request:
This one's a little odd to test because the translations come from WordPress.org, and won't be updated there until the plugin itself is updated. The testing steps below attempt to work around that, but don't create a 1:1 experience with what reality will be:
npm run build
./languages
directory to the plugin. It should contain one.mo
file with Spanish translations. languages.zipOther information: