fix: handle inactive woocommerce #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
requested changes
Feb 19, 2024
| @@ -79,6 +79,9 @@ public static function filter_lists( $lists ) { | |||
| if ( ! is_array( $lists ) || empty( $lists ) ) { | |||
| return $lists; | |||
| } | |||
| if ( ! function_exists( 'wc_memberships_is_post_content_restricted' ) ) { | |||
There was a problem hiding this comment.
Hmm so apparently this happens if woo memberships is active but woocommerce is not.
I think it's best to fix the check on the init method, that checks class_exists( 'WC_Memberships_Loader' ). If Woo and/or Woo memberships is not active, the hooks should not even be initalized
There was a problem hiding this comment.
Good idea, added in acacf58
leogermani
approved these changes
Feb 20, 2024
github-actions
bot
added
[Status] Approved
6 tasks
|
🎉 This PR is included in version 2.12.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 25, 2024
# [2.12.0](v2.11.2...v2.12.0) (2024-03-25) ### Bug Fixes * handle inactive woocommerce ([#1437](#1437)) ([b369d54](b369d54)) * **mc:** log add_user_to_lists errors ([#1444](#1444)) ([c53b02a](c53b02a)) ### Features * update translation strings ([#1435](#1435)) ([822c7e1](822c7e1)) ### Reverts * chore(release): 2.12.0-alpha.1 to avoid conflicts [skip ci] ([4ba5000](4ba5000))
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Add a check for WC function existence.
How to test the changes in this Pull Request:
Should be self-explanatory, but if testing is needed – I've encountered this after deactivating
woocommerceand editing a post. PHP Errors are logged in this situation ontrunk.Other information: