Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#1594 done again after its base epic branch got merged leaving it behind
In the effort of consolidating our data flows, we want to enforce that every contact update goes through the same route, starting at
Newspack_Newsletters_Contacts
class to make sure we have the propper logging.However, we can't make all the internal methods private or protected.
This PHP Sniffer helps us avoid adding any new code that will bypass our intended flow. We'll need to add this sniffers to other Newspack plugins as well. - TBD how to do that
How to test the changes in this Pull Request:
./vendor/bin/phpcs
PS - the linting errors in the CI job are expected until we merge #1574
Other information: