fix(phpcs): specify path in custom ruleset ref #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miguelpeixe
approved these changes
Aug 30, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Sep 4, 2024
# [3.2.0-alpha.2](v3.2.0-alpha.1...v3.2.0-alpha.2) (2024-09-04) ### Bug Fixes * error handling, tests, CI builds ([#1641](#1641), [#1642](#1642)) ([791fdc3](791fdc3)) * handle missing Mailchimp API key ([83a0d6f](83a0d6f)) * **phpcs:** specify path in custom ruleset ref ([#1637](#1637)) ([28f5b50](28f5b50)) ### Reverts * "chore(deps-dev): bump @wordpress/browserslist-config from 6.5.0 to 6.6.0" ([f08f271](f08f271))
|
🎉 This PR is included in version 3.2.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dkoo
added a commit
that referenced
this pull request
Sep 12, 2024
matticbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
# [3.2.0](v3.1.7...v3.2.0) (2024-10-08) ### Bug Fixes * a typo that came after a refactor ([#1656](#1656)) ([0ae5b61](0ae5b61)) * dont send metadata on subscribe ([#1648](#1648)) ([5b4a059](5b4a059)) * handle missing Mailchimp API key ([83a0d6f](83a0d6f)) * **mailchimp:** allow contacts to resubscribe after unsubscribing ([#1654](#1654)) ([b76dbc2](b76dbc2)) * **phpcs:** specify path in custom ruleset ref ([#1637](#1637)) ([28f5b50](28f5b50)) ### Features * **mailchimp:** parse contact name into merge fields ([#1628](#1628)) ([aeba65a](aeba65a)) * **styling:** list styles ([e9ea4dd](e9ea4dd)), closes [#1335](#1335) ### Reverts * "chore(deps-dev): bump @wordpress/browserslist-config from 6.5.0 to 6.6.0" ([f08f271](f08f271))
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Same as Automattic/newspack-plugin#3384 but for this repo.
#1611 implemented some custom PHPCS sniffs, but for some reason the
<rule ref="phpcsSniffs" />causes my IDE to fail to find them unless I specify a relative path from the repo's root directory.How to test the changes in this Pull Request:
If you use VS Code + a PHPCS/PHPCBF extension, you may observe on
trunkthat attempting to lint or fix errors throws an error about not being able to find the referenced sniff. This should fix it.Other information: