Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove CodeMirror/CSSLint to reduce bundle size & speed #1642

Merged

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Sep 3, 2024

All Submissions:

Changes proposed in this Pull Request:

Removes some heavy front-end libraries (CodeMirror and CSSLint) to reduce webpack bundle size and build time, to hopefully avoid timeouts when running build jobs on CI.

BREAKING CHANGE: makes the UI for editing custom CSS a little plainer and less user-friendly, and removes lint-as-you-type features for this UI.

How to test the changes in this Pull Request:

  1. Create or edit a newsletter post
  2. Go to Newsletter Styles in the "More" menu:
Screenshot 2024-09-03 at 3 05 05 PM
  1. Expand the "Custom CSS" panel and confirm there's a plain-text input here.
  2. Enter some valid custom CSS and confirm that the editor preview updates with the styles in real-time:
Screenshot 2024-09-03 at 3 05 27 PM
  1. Save, refresh, and confirm that the styles are saved and reloaded correctly (you can also check the custom_css meta value on the post).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Status] Needs Review dependencies Pull requests that update a dependency file labels Sep 3, 2024
@dkoo dkoo self-assigned this Sep 3, 2024
@dkoo dkoo requested a review from a team as a code owner September 3, 2024 21:08
@dkoo dkoo mentioned this pull request Sep 3, 2024
6 tasks
@dkoo dkoo changed the title perf: remove CodeMirror to reduce bundle size & speed perf: remove CodeMirror/CSSLint to reduce bundle size & speed Sep 3, 2024
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adekbadek adekbadek merged commit b8a9232 into hotfix/constant-contact-error-contact Sep 4, 2024
11 checks passed
@adekbadek adekbadek deleted the fix/remove-codemirror branch September 4, 2024 07:52
@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Sep 4, 2024
adekbadek added a commit that referenced this pull request Sep 4, 2024
Co-authored-by: dkoo <derrick.koo@automattic.com>
Co-authored-by: leogermani <leogermani@automattic.com>
matticbot pushed a commit that referenced this pull request Sep 4, 2024
## [3.1.1](v3.1.0...v3.1.1) (2024-09-04)

### Bug Fixes

* error handling, tests, CI builds ([#1641](#1641), [#1642](#1642)) ([791fdc3](791fdc3))
matticbot pushed a commit that referenced this pull request Sep 4, 2024
# [3.2.0-alpha.2](v3.2.0-alpha.1...v3.2.0-alpha.2) (2024-09-04)

### Bug Fixes

* error handling, tests, CI builds ([#1641](#1641), [#1642](#1642)) ([791fdc3](791fdc3))
* handle missing Mailchimp API key ([83a0d6f](83a0d6f))
* **phpcs:** specify path in custom ruleset ref ([#1637](#1637)) ([28f5b50](28f5b50))

### Reverts

* "chore(deps-dev): bump @wordpress/browserslist-config from 6.5.0 to 6.6.0" ([f08f271](f08f271))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file [Status] Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants