feat(mailchimp): parse contact name into merge fields #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #1628 +/- ##
============================================
- Coverage 20.81% 20.81% -0.01%
- Complexity 2389 2391 +2
============================================
Files 46 46
Lines 8952 8957 +5
============================================
+ Hits 1863 1864 +1
- Misses 7089 7093 +4 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 30, 2024
dkoo
approved these changes
Sep 4, 2024
github-actions
bot
added
[Status] Approved
dkoo
requested changes
Sep 4, 2024
dkoo
approved these changes
Sep 4, 2024
dkoo
pushed a commit
that referenced
this pull request
Sep 12, 2024
matticbot
pushed a commit
that referenced
this pull request
Sep 20, 2024
# [3.2.0-alpha.4](v3.2.0-alpha.3...v3.2.0-alpha.4) (2024-09-20) ### Bug Fixes * a typo that came after a refactor ([#1656](#1656)) ([0ae5b61](0ae5b61)) * automatically retry failed scheduled sends ([#1660](#1660)) ([e0cca64](e0cca64)) * **cc:** urlencode query args before passing to CC API ([#1659](#1659)) ([4f645d2](4f645d2)) * dont send metadata on subscribe ([#1648](#1648)) ([5b4a059](5b4a059)) * handle encoded URLs and block patterns in redirect check ([#1635](#1635)) ([2fa5d16](2fa5d16)) * **mailchimp:** allow contacts to resubscribe after unsubscribing ([#1654](#1654)) ([b76dbc2](b76dbc2)) ### Features * **mailchimp:** parse contact name into merge fields ([#1628](#1628)) ([aeba65a](aeba65a))
|
🎉 This PR is included in version 3.2.0-alpha.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
# [3.2.0](v3.1.7...v3.2.0) (2024-10-08) ### Bug Fixes * a typo that came after a refactor ([#1656](#1656)) ([0ae5b61](0ae5b61)) * dont send metadata on subscribe ([#1648](#1648)) ([5b4a059](5b4a059)) * handle missing Mailchimp API key ([83a0d6f](83a0d6f)) * **mailchimp:** allow contacts to resubscribe after unsubscribing ([#1654](#1654)) ([b76dbc2](b76dbc2)) * **phpcs:** specify path in custom ruleset ref ([#1637](#1637)) ([28f5b50](28f5b50)) ### Features * **mailchimp:** parse contact name into merge fields ([#1628](#1628)) ([aeba65a](aeba65a)) * **styling:** list styles ([e9ea4dd](e9ea4dd)), closes [#1335](#1335) ### Reverts * "chore(deps-dev): bump @wordpress/browserslist-config from 6.5.0 to 6.6.0" ([f08f271](f08f271))
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This is part of the refactor in progress here: Automattic/newspack-plugin#3362
Incoming
$contact['name']should be transformed to populate theFirst NameandLast Namemerge fields.How to test the changes in this Pull Request:
Other information: