Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #3050 due to performance issues #3059

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: revert #3050 due to performance issues #3059

merged 1 commit into from
Apr 11, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Apr 11, 2024

All Submissions:

Changes proposed in this Pull Request:

Reverts #3050 due to performance issues on sites with many memberships.

How to test the changes in this Pull Request:

Nothing to test—simply reverts problematic changes from v3.6.0.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 11, 2024
@dkoo dkoo self-assigned this Apr 11, 2024
@dkoo dkoo requested a review from a team as a code owner April 11, 2024 02:19
@dkoo dkoo merged commit a986c17 into trunk Apr 11, 2024
7 checks passed
@dkoo dkoo deleted the fix/revert-3050 branch April 11, 2024 02:30
dkoo added a commit that referenced this pull request Apr 11, 2024
dkoo added a commit that referenced this pull request Apr 11, 2024
matticbot pushed a commit that referenced this pull request Apr 11, 2024
## [3.6.5](v3.6.4...v3.6.5) (2024-04-11)

### Bug Fixes

* revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([1d45d9e](1d45d9e))
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@claudiulodro claudiulodro added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 11, 2024
matticbot pushed a commit that referenced this pull request Apr 11, 2024
# [3.7.0-alpha.1](v3.6.7...v3.7.0-alpha.1) (2024-04-11)

### Bug Fixes

* prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79))
* **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3))
* revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17))

### Features

* support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 24, 2024
# [3.7.0](v3.6.13...v3.7.0) (2024-04-24)

### Bug Fixes

* prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79))
* **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3))
* revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17))

### Features

* support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants