fix(reader-reg-block): respect newsletter subscription checkbox state #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
added
the
[Status] Needs Review
adekbadek
approved these changes
Apr 5, 2024
github-actions
bot
added
[Status] Approved
chickenn00dle
deleted the
fix/respect-subscribe-checkbox-selection-in-reader-reg-block
branch
matticbot
pushed a commit
that referenced
this pull request
Apr 11, 2024
# [3.7.0-alpha.1](v3.6.7...v3.7.0-alpha.1) (2024-04-11) ### Bug Fixes * prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79)) * **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3)) * revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17)) ### Features * support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
|
🎉 This PR is included in version 3.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Apr 24, 2024
# [3.7.0](v3.6.13...v3.7.0) (2024-04-24) ### Bug Fixes * prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79)) * **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3)) * revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17)) ### Features * support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1200550061930446/1206911937712363/f
Fixes an issue where the reader registration block was not respecting the newsletter subscription checkbox state:
How to test the changes in this Pull Request:
Subscribe to our newslettercheckbox is checked in the editortrunkthe checkbox will not be checked by default. On this branch it willOther information: