-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure active status for memberships tied to active subs #3050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observe that the membership is updated to "expired" status with an "Expires" date matching when you changed the subscription status.
I can't reproduce the issue on the release
branch. After cancelling the subscription, the membership enters "Pending Cancellation" state (my test product is a monthly subscription, so the membership is active for another month still), not "Expired".
What about if you force it into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing. I like how defensively this is coded too!
## [3.6.1](v3.6.0...v3.6.1) (2024-04-09) ### Bug Fixes * ensure active status for memberships tied to active subs ([#3050](#3050)) ([b74a06d](b74a06d))
🎉 This PR is included in version 3.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [3.7.0-alpha.1](v3.6.7...v3.7.0-alpha.1) (2024-04-11) ### Bug Fixes * prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79)) * **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3)) * revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17)) ### Features * support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
# [3.7.0](v3.6.13...v3.7.0) (2024-04-24) ### Bug Fixes * prevent multiple inputs from resetting in autocompletetokenfield component ([#3023](#3023)) ([7f30d79](7f30d79)) * **reader-reg-block:** respect newsletter subscription checkbox state ([#3024](#3024)) ([02728d3](02728d3)) * revert [#3050](#3050) due to performance issues ([#3059](#3059)) ([a986c17](a986c17)) ### Features * support for MC tags as subscription lists ([#3035](#3035)) ([c363630](c363630))
All Submissions:
Changes proposed in this Pull Request:
Fixes what seems to be a bug in the WC Memberships plugin. When the same user has both a previously expired/cancelled subscription and a newer active one, the "Expires" date from the expired/cancelled subscription forces the user's membership to a
expired
status, even though the newer subscription is still active and should grant membership.How to test the changes in this Pull Request:
relase
, in WP admin, confim that the membership gets reassociated with the new active subscription. But observe that it gets set to "active" status and then immediately to "expired" status again due to the persistence of the "Expires" date from the first cancelled subscription.Other information: