fix: hourly cron job to check for prematurely expired memberships #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
the
[Status] Needs Review
claudiulodro
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Looks solid. I think we may run into scalability issues if it's processing thousands of subscriptions, but since it's cron it won't really affect the site functionality and there are a few different ways we can adjust it to compensate. I'd like to see if it does run into issues first though :)
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [3.6.8](v3.6.7...v3.6.8) (2024-04-11) ### Bug Fixes * hourly cron job to check for prematurely expired memberships ([#3060](#3060)) ([77eeee3](77eeee3))
|
🎉 This PR is included in version 3.6.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Apr 11, 2024
# [3.7.0-alpha.2](v3.7.0-alpha.1...v3.7.0-alpha.2) (2024-04-11) ### Bug Fixes * hourly cron job to check for prematurely expired memberships ([#3060](#3060)) ([77eeee3](77eeee3))
|
🎉 This PR is included in version 3.7.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Addresses the same issue as in #3050, but with a more performant approach.
Rather than filtering data at the moment any membership/subscription is fetched, this implements an hour cron job that iterates through all active subscriptions on the site, checks any memberships associated with those subscriptions, and reactivates memberships that aren't in an active state. This should ensure that anyone with an active subscription should have access to the memberships their subscription(s) grant them.
How to test the changes in this Pull Request:
Follow the same testing instructions as in #3050, but also note that if you have
define( 'NEWSPACK_LOG_LEVEL', 2 );defined in wp-config.php, you'll see some additional logging showing that the cron job is working:Other information: