feat: add product option to autocomplete orders

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

When a new order is paid for in WooCommerce, the default behavior is to move the order into processing status and require a store admin to manually move it to completed status, unless the order contains only products that are both virtual and downloadable. If an order never moves to completed status, any data events connected to the order_completed hook (including RAS contact data syncing) will never happen. This is counterintuitive to most Newspack publishers, who simply want the orders to complete automatically without manual intervention.

This PR adds a new "Auto-complete orders" option to all products and product variations, ON by default, which lets orders with those products autocomplete regardless of whether they're virtual and/or downloadable. This essentially changes the default behavior so that orders will be autocompleted unless the "Auto-complete orders" option is intentionally unchecked for a product or variation.

Note that this should be considered a breaking change because it will alter the default order processing behavior for existing products across all Newspack sites.

How to test the changes in this Pull Request:

1. On trunk, create a new simple product (one-time or subscription) and a variable product (one-time or subscription). Make sure the products and all variations are NOT downloadable.
2. As a reader, purchase the simple + variable products.
3. In WP admin > WooCommerce > Orders, observe that the orders are stuck in processing status unless you manually update them to complete.
4. Check out this branch and edit the products you created in step 1. Confirm there's a new "Auto-complete orders" option for the simple product and each variation, checked by default. Don't change anything yet.
5. Purchase the products as a reader again, but this time confirm that these orders do automatically finish in completed status without requiring manual intervention.
6. Edit the products again and uncheck the "Auto-complete orders" option.
7. Purchase the products as a reader again, and confirm that these orders again get stuck in processing status unless you manually update them to complete (this lets you restore Woo's default order processing behavior on a per-product basis, if needed).

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206970859525478

[adekbadek]

Is there a use case where an order for a virtual product should not be completed immediately? If not, then I don't think there's need for UI or a custom product option here. Instead, the "downloadable & virtual" condition could be changed to just "virtual" ('woocommerce_order_item_needs_processing' filter).

[dkoo]

Is there a use case where an order for a virtual product should not be completed immediately?

I don't think we can confidently answer this for all Newspack sites, hence offering the option as an escape hatch.

[claudiulodro]

Is there a use case where an order for a virtual product should not be completed immediately?

There are a couple I can think of, like selling ads or (virtual) event tickets, where there are further logistics needed after someone gives money.

[adekbadek]

Pre-approving with one question. If the answer is no then we're good to go here.

Note that this should be considered a breaking change because it will alter the default order processing behavior for existing products across all Newspack sites.

Don't forget a "BREAKING CHANGE" string in the squashed commit message.

[matticbot]

🎉 This PR is included in version 4.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀