Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wrapping rss titles in CDATA #3104

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

claudiulodro
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1200550061930446/1207116490077225/f

This PR adds a new setting to RSS Enhancements which will allow a feed to have <title> elements wrapped in CDATA. This is necessary for some RSS parsers that will have issues processing <title> elements when there are special characters in the post title.

How to test the changes in this Pull Request:

  1. Create a new RSS feed. Check the "Wrap the content of <title> elements in CDATA tags" setting.
  2. View the feed. Titles elements should look like <title><![CDATA[Post title]]></title>.
  3. Uncheck the setting. View the feed. Title elements should look like <title>Post title</title>

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label May 8, 2024
@claudiulodro claudiulodro requested a review from a team as a code owner May 8, 2024 18:09
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 9, 2024
@claudiulodro claudiulodro merged commit 8b3a3be into trunk May 9, 2024
8 checks passed
@claudiulodro claudiulodro deleted the add/pugpig-rss branch May 9, 2024 19:12
matticbot pushed a commit that referenced this pull request May 20, 2024
# [4.0.0-alpha.6](v4.0.0-alpha.5...v4.0.0-alpha.6) (2024-05-20)

### Bug Fixes

* **data-events:** handle no ga_client_id in data ([fc4fc9f](fc4fc9f))
* **registration-block:** prevent undefined variable warning ([8af9d89](8af9d89))
* **starter-content:** make the starter content generation idempotent ([d5e10ff](d5e10ff))

### Features

* **cli:** command to migrate CAP guest authors to WP users ([#3068](#3068)) ([7ea8273](7ea8273))
* custom role for assignable authors who don't edit posts ([#3066](#3066)) ([7b89053](7b89053))
* support for wrapping rss titles in cdata ([#3104](#3104)) ([8b3a3be](8b3a3be))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 28, 2024
# [4.0.0](v3.8.8...v4.0.0) (2024-05-28)

### Bug Fixes

* autocomplete orders only for virtual products ([#3111](#3111)) ([bfbe554](bfbe554))
* **data-events:** handle no ga_client_id in data ([fc4fc9f](fc4fc9f))
* ensure only admins can reset starter content and newspack options ([#3081](#3081)) ([4606721](4606721))
* **registration-block:** prevent undefined variable warning ([8af9d89](8af9d89))
* **starter-content:** make the starter content generation idempotent ([d5e10ff](d5e10ff))

### Features

* add product option to autocomplete orders ([#3072](#3072)) ([4a2859b](4a2859b))
* **cli:** command to migrate CAP guest authors to WP users ([#3068](#3068)) ([7ea8273](7ea8273))
* custom role for assignable authors who don't edit posts ([#3066](#3066)) ([7b89053](7b89053))
* **ras:** skip campaign setup ([#3051](#3051)) ([9ef0e6d](9ef0e6d))
* support for wrapping rss titles in cdata ([#3104](#3104)) ([8b3a3be](8b3a3be))

### BREAKING CHANGES

* Changes order autocompletion behavior for existing products!

* feat: add product option to autocomplete orders

* chore: update outdated docblock description
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released on @epic/ras-acc released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants