Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom role for assignable authors who don't edit posts #3066

Merged
merged 2 commits into from
May 9, 2024
Merged

feat: custom role for assignable authors who don't edit posts #3066

merged 2 commits into from
May 9, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Apr 15, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Some publishers want to assign authorship of posts to users, but don't want these users to be able to log in. User stories:

👉 As a publisher, I want to assign a user as post author, without this author being able to edit site content
👉 As a publisher, I want to be able to update an existing subscriber, so that they can be assigned as a post author, without them being able to edit site content

See 1200550061930446-as-1206481527608031/f

How to test the changes in this Pull Request:

  1. Ensure co-authors-plus and woocommerce plugins are installed & activated
  2. Create a new user and assign the new "Not Editing Contributor" role to them
  3. Assign the user as a post author
  4. View the post on the front-end and confirm the user is assigned as the post author and has an author archive page
  5. Log in as the user, observe you don't have access to /wp-admin pages
  6. Visit the "My Account" page, try to change the name and observe it's not allowed for this kind of user
  7. Log in as a site reader, observe the name on the "My Account" page can be updated

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 15, 2024
@adekbadek adekbadek requested a review from a team as a code owner April 15, 2024 13:16
@adekbadek adekbadek force-pushed the feat/contributor-no-edit-role branch from 15987be to 3eec99b Compare April 17, 2024 15:08
@adekbadek adekbadek mentioned this pull request Apr 18, 2024
Merged
6 tasks
@adekbadek @claudiulodro
Update includes/plugins/class-co-authors-plus.php
0162461 
Co-authored-by: Claudiu Lodromanean <claudiulodro@gmail.com>
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 9, 2024
@adekbadek adekbadek merged commit 7b89053 into trunk May 9, 2024
7 checks passed
@adekbadek adekbadek deleted the feat/contributor-no-edit-role branch May 9, 2024 13:36
matticbot pushed a commit that referenced this pull request May 20, 2024
@semantic-release-bot
chore(release): 4.0.0-alpha.6 [skip ci]
2f1bfa3 
# [4.0.0-alpha.6](v4.0.0-alpha.5...v4.0.0-alpha.6) (2024-05-20)

### Bug Fixes

* **data-events:** handle no ga_client_id in data ([fc4fc9f](fc4fc9f))
* **registration-block:** prevent undefined variable warning ([8af9d89](8af9d89))
* **starter-content:** make the starter content generation idempotent ([d5e10ff](d5e10ff))

### Features

* **cli:** command to migrate CAP guest authors to WP users ([#3068](#3068)) ([7ea8273](7ea8273))
* custom role for assignable authors who don't edit posts ([#3066](#3066)) ([7b89053](7b89053))
* support for wrapping rss titles in cdata ([#3104](#3104)) ([8b3a3be](8b3a3be))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
a28f9e4 
# [4.0.0](v3.8.8...v4.0.0) (2024-05-28)

### Bug Fixes

* autocomplete orders only for virtual products ([#3111](#3111)) ([bfbe554](bfbe554))
* **data-events:** handle no ga_client_id in data ([fc4fc9f](fc4fc9f))
* ensure only admins can reset starter content and newspack options ([#3081](#3081)) ([4606721](4606721))
* **registration-block:** prevent undefined variable warning ([8af9d89](8af9d89))
* **starter-content:** make the starter content generation idempotent ([d5e10ff](d5e10ff))

### Features

* add product option to autocomplete orders ([#3072](#3072)) ([4a2859b](4a2859b))
* **cli:** command to migrate CAP guest authors to WP users ([#3068](#3068)) ([7ea8273](7ea8273))
* custom role for assignable authors who don't edit posts ([#3066](#3066)) ([7b89053](7b89053))
* **ras:** skip campaign setup ([#3051](#3051)) ([9ef0e6d](9ef0e6d))
* support for wrapping rss titles in cdata ([#3104](#3104)) ([8b3a3be](8b3a3be))

### BREAKING CHANGES

* Changes order autocompletion behavior for existing products!

* feat: add product option to autocomplete orders

* chore: update outdated docblock description
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees
No one assigned
Labels
released on @alpha released on @epic/ras-acc released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @matticbot @claudiulodro