Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show comments on metered paywall posts #3057

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

claudiulodro
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Note: This is a hotfix

Fixes an issue discovered around the metered wall functionality: when a metered wall is in place, comments always get hidden for anonymous users.

How to test the changes in this Pull Request:

  1. Add a membership plan and set it to restrict all posts. Set up a metered wall that gives anonymous readers 1 pageview. Make one or more comments on a post.
  2. Before applying this patch, visit the post in an incognito window. Observe no comments are shown:
Screenshot 2024-04-10 at 12 14 21 PM 4. Apply this patch. Refresh the page. Observe comments are shown: Screenshot 2024-04-10 at 12 14 36 PM 5. Visit a different post. Observe the registration wall continues to block you after you've exceeded your post quota.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 10, 2024
@claudiulodro claudiulodro requested a review from a team as a code owner April 10, 2024 19:18
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described!

The comments are visible (and posts are comment-able) on metered posts when the reader can still view the full post, but the comments and comment form are hidden when they can't see the full post.

I tested this both with the inline and overlay gate, and with commenting open to all readers and limited to only users who were already registered on the site 🚢

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 10, 2024
@claudiulodro claudiulodro merged commit f06e86f into release Apr 10, 2024
8 checks passed
@claudiulodro claudiulodro deleted the fix/membership-comments branch April 10, 2024 22:49
matticbot pushed a commit that referenced this pull request Apr 10, 2024
## [3.6.4](v3.6.3...v3.6.4) (2024-04-10)

### Bug Fixes

* dont hide comments on metered paywall posts ([#3057](#3057)) ([f06e86f](f06e86f))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants