Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert 3057 #3063

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: revert 3057 #3063

merged 1 commit into from
Apr 12, 2024

Conversation

claudiulodro
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

#3057 in conjunction with some cron job seems to cause some sort of issue that fills up the logs with millions of notices a minute. This PR rolls that change back so we can re-approach the problem in some other way that should have less side-effects.

How to test the changes in this Pull Request:

  1. Stop after the second testing instruction at Show comments on metered paywall posts #3057

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 12, 2024
@claudiulodro claudiulodro requested a review from a team as a code owner April 12, 2024 18:23
laurelfulford
laurelfulford approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described so I'm approving, but should this be cherry-picked and turned into a hotfix PR instead?

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 12, 2024
@claudiulodro
Copy link
Contributor Author

Shoot, yes, forgot to do it to the right branch. 1 sec

@claudiulodro claudiulodro changed the base branch from trunk to release April 12, 2024 18:41
@claudiulodro
Copy link
Contributor Author

Ok it's to release now

@claudiulodro claudiulodro merged commit 25eea61 into release Apr 12, 2024
8 checks passed
@claudiulodro claudiulodro deleted the fix/revert-comment-fix branch April 12, 2024 18:42
@laurelfulford
Copy link
Contributor

Beauty! 🙌

matticbot pushed a commit that referenced this pull request Apr 12, 2024
@semantic-release-bot
chore(release): 3.6.9 [skip ci]
a5b1e86 
## [3.6.9](v3.6.8...v3.6.9) (2024-04-12)

### Bug Fixes

* revert 3057 ([#3063](#3063)) ([25eea61](25eea61))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 12, 2024
@semantic-release-bot
chore(release): 3.7.0-alpha.3 [skip ci]
29fc12a 
# [3.7.0-alpha.3](v3.7.0-alpha.2...v3.7.0-alpha.3) (2024-04-12)

### Bug Fixes

* revert 3057 ([#3063](#3063)) ([25eea61](25eea61))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.7.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claudiulodro @laurelfulford @matticbot