fix: update dependencies to avoid conflict in WP 6.6 #3181

dkoo · 2024-06-13T21:54:47Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Refactoring required for changes in Automattic/newspack-scripts#209. Note that this PR will not pass CI tests and should NOT be merged until Automattic/newspack-scripts#209 is released as an NPM package, so this repo can install it as a dependency.

Note: this PR also renames the assets folder to src to bring this repo in line with all other Newspack repos' directory structure.

How to test the changes in this Pull Request:

Follow instructions in Automattic/newspack-scripts#209.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

ress/* packages

adekbadek

The only issue I've found is that the linting and typescript checking is broken with these changes. Are these proxy scripts necessary?

package.json

src/components/src/image-upload/index.test.js

package.json

…script

miguelpeixe

No major issues while testing, the only problem I found is what appears to be a conflict between the auto js formatter and the typescript check, which is probably what @adekbadek also identified in his first review.

npm run typescript:check passes with the current formatting, but after the changes from npm run format:js I get a bunch of errors like this on the ts check:

src/wizards/engagement/components/prompt.tsx:245:20 - error TS2339: Property 'indexOf' does not exist on type 'string | number | boolean | number[] | string[]'.
  Property 'indexOf' does not exist on type 'number'.

245                 ]?.indexOf(
                       ~~~~~~~

I don't think it's a blocking issue for now but we'll need to figure out how to adapt the rules so we don't break ts once we commit the rules from the auto formatter.

dkoo · 2024-08-01T17:53:35Z

@miguelpeixe I'd say the conflict between formatting and TS rules is non-blocking for now, as I don't think we should reformat our JS at this point because the newer rules in @wordpress/scripts would result in a huge number of changes in our JS across all repos. If we decide to change our JS formatting to match, we should do so in future PRs and separately from these other changes, and then we can resolve the conflict with our TS rules.

TS checks fixed. See #3181 (comment)

@wordp

# [5.0.0-alpha.1](v4.8.0-alpha.3...v5.0.0-alpha.1) (2024-08-02) ### Bug Fixes * **data-events:** ensure get_last_successful_order returns WC_Order ([222f58c](222f58c)) * update dependencies to support `@wordpress/scripts` ([#3181](#3181)) ([0d35ac8](0d35ac8)) ### Features * rename guest contributor role ([#3302](#3302)) ([c7f6917](c7f6917)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for updating dependencies in newspack-scripts * chore: JS formatting fixes for eslint errors * chore: update NPM scripts and other dependencies * chore: fix jest unit tests * chore: update dependencies in newspack-components * fix: peer dependency conflicts with @wordp ress/* packages * chore: update newspack-components dependencies * chore: proxy stylelint from newspack-scripts * chore: remove unnecessary stylelint * refactor: use proxy script for eslint and stylelint scripts * chore: remove console.log * chore: update newspack-scripts to NPM alpha version * chore: update newspack-scripts to git branch * chore: update newspack-scripts to alpha.3 * test: remove unneeded mocks * deps: newspack-scripts@5.6.0-alpha.1 * chore: fix scripts * fix: update newspack-scripts to v5.6.0-alpha.2 * fix: add newspack-revisions.js to webpack build for linting * fix: update stylelint and format CSS for errors * chore: clear TS check errors * fix: start command * fix: remove i18n script (Blocks only) * temporarily revert stylelint autoformat to avoid merge conflicts * chore: add .stylelintrc.js * fix: reformat SCSS * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * style: stylelint autofixes * fix: add fix:js script; temporarily remove format:js * fix: update newspack-scripts to v5.5.0-alpha.8 and restore format:js script * chore: add NPM scripts for PHP * refactor: move recaptcha JS to src directory * fix: ignore dist and node_modules inside src/components, too * fix: update Babel configs for components * fix(components): output TS and JS, and publish new major version to NPM * fix: do not delete node_modules after post-publish * chore: bump newspack-scripts to v5.5.2

matticbot · 2024-08-02T20:43:00Z

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@wordp

# [5.0.0](v4.7.0...v5.0.0) (2024-08-13) ### Bug Fixes * **data-events:** ensure get_last_successful_order returns WC_Order ([222f58c](222f58c)) * **data-events:** ensure get_last_successful_order returns WC_Order ([#3299](#3299)) ([da21561](da21561)) * **data-events:** race condition between `order_completed` and `subscription_updated` ([#3314](#3314)) ([afbf2e8](afbf2e8)) * force active membership if the user has active subs ([#3268](#3268)) ([aebe581](aebe581)) * namespacing issue ([7b1506a](7b1506a)) * update dependencies to support `@wordpress/scripts` ([#3181](#3181)) ([0d35ac8](0d35ac8)) * **woocommerce:** prevent /shop redirect from author archives ([46db669](46db669)) ### Features * enhancements for the Non editing contributor role ([#3277](#3277)) ([e47e422](e47e422)) * **ga4:** filter custom params ([eda5553](eda5553)) * rename guest contributor role ([#3302](#3302)) ([76ac05e](76ac05e)) * rename guest contributor role ([#3302](#3302)) ([c7f6917](c7f6917)) * show deprecation warning for CM in Engagement wizard ([#3264](#3264)) ([0813369](0813369)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for updating dependencies in newspack-scripts * chore: JS formatting fixes for eslint errors * chore: update NPM scripts and other dependencies * chore: fix jest unit tests * chore: update dependencies in newspack-components * fix: peer dependency conflicts with @wordp ress/* packages * chore: update newspack-components dependencies * chore: proxy stylelint from newspack-scripts * chore: remove unnecessary stylelint * refactor: use proxy script for eslint and stylelint scripts * chore: remove console.log * chore: update newspack-scripts to NPM alpha version * chore: update newspack-scripts to git branch * chore: update newspack-scripts to alpha.3 * test: remove unneeded mocks * deps: newspack-scripts@5.6.0-alpha.1 * chore: fix scripts * fix: update newspack-scripts to v5.6.0-alpha.2 * fix: add newspack-revisions.js to webpack build for linting * fix: update stylelint and format CSS for errors * chore: clear TS check errors * fix: start command * fix: remove i18n script (Blocks only) * temporarily revert stylelint autoformat to avoid merge conflicts * chore: add .stylelintrc.js * fix: reformat SCSS * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * style: stylelint autofixes * fix: add fix:js script; temporarily remove format:js * fix: update newspack-scripts to v5.5.0-alpha.8 and restore format:js script * chore: add NPM scripts for PHP * refactor: move recaptcha JS to src directory * fix: ignore dist and node_modules inside src/components, too * fix: update Babel configs for components * fix(components): output TS and JS, and publish new major version to NPM * fix: do not delete node_modules after post-publish * chore: bump newspack-scripts to v5.5.2

matticbot · 2024-08-13T07:36:03Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dkoo added 4 commits June 13, 2024 09:34

chore: refactor for updating dependencies in newspack-scripts

755154b

chore: JS formatting fixes for eslint errors

e38e5ea

chore: update NPM scripts and other dependencies

9185e74

chore: fix jest unit tests

f6b1ed5

dkoo force-pushed the chore/update-dependencies branch from af05b67 to f6b1ed5 Compare June 13, 2024 22:46

dkoo added 5 commits June 13, 2024 17:38

chore: update dependencies in newspack-components

a4a4355

fix: peer dependency conflicts with @wordp

2253022

ress/* packages

chore: update newspack-components dependencies

34016d5

chore: proxy stylelint from newspack-scripts

2ce1471

chore: remove unnecessary stylelint

db30339

dkoo self-assigned this Jun 14, 2024

dkoo added [Status] Needs Review The issue or pull request needs to be reviewed Do Not Merge! dependencies Pull requests that update a dependency file labels Jun 14, 2024

dkoo marked this pull request as ready for review June 14, 2024 23:00

dkoo requested a review from a team as a code owner June 14, 2024 23:00

dkoo mentioned this pull request Jun 14, 2024

fix: update dependencies to support @wordpress/scripts Automattic/newspack-scripts#209

Merged

5 tasks

dkoo and others added 8 commits June 17, 2024 10:59

refactor: use proxy script for eslint and stylelint scripts

c095f51

chore: remove console.log

657f385

chore: update newspack-scripts to NPM alpha version

1f638f9

chore: update newspack-scripts to git branch

2447a58

chore: update newspack-scripts to alpha.3

365b010

Merge trunk into chore/update-dependencies

661d026

test: remove unneeded mocks

b27dbd7

deps: newspack-scripts@5.6.0-alpha.1

2039072

adekbadek previously requested changes Jun 18, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/components/src/image-upload/index.test.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

dkoo added 4 commits June 19, 2024 11:37

chore: fix scripts

74f78f3

fix: update newspack-scripts to v5.6.0-alpha.2

eb1f9ca

fix: add newspack-revisions.js to webpack build for linting

d5ea530

fix: update stylelint and format CSS for errors

76e4cc8

adekbadek and others added 4 commits June 24, 2024 15:02

Merge branch 'trunk' into chore/update-dependencies

6dc28a5

style: stylelint autofixes

9cc319d

Merge branch 'trunk' into chore/update-dependencies

741ab3f

fix: add fix:js script; temporarily remove format:js

c580196

dkoo requested a review from adekbadek June 25, 2024 21:54

dkoo added 10 commits June 25, 2024 17:41

fix: update newspack-scripts to v5.5.0-alpha.8 and restore format:js …

ebf4197

…script

Merge branch 'trunk' into chore/update-dependencies

5c59f7a

chore: add NPM scripts for PHP

dc91530

refactor: move recaptcha JS to src directory

672d4dc

fix: ignore dist and node_modules inside src/components, too

c2d6524

fix: update Babel configs for components

88fcfe9

fix(components): output TS and JS, and publish new major version to NPM

9b77c80

fix: do not delete node_modules after post-publish

3aad6b5

Merge branch 'trunk' into chore/update-dependencies

aaf0846

Merge branch 'trunk' into chore/update-dependencies

a11ec80

miguelpeixe reviewed Aug 1, 2024

View reviewed changes

miguelpeixe approved these changes Aug 2, 2024

View reviewed changes

chore: bump newspack-scripts to v5.5.2

3dede67

dkoo removed the Do Not Merge! label Aug 2, 2024

Merge branch 'trunk' into chore/update-dependencies

7464171

dkoo merged commit 0d35ac8 into trunk Aug 2, 2024
8 checks passed

dkoo deleted the chore/update-dependencies branch August 2, 2024 20:32

matticbot added the released on @alpha label Aug 2, 2024

matticbot added the released label Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update dependencies to avoid conflict in WP 6.6 #3181

fix: update dependencies to avoid conflict in WP 6.6 #3181

dkoo commented Jun 13, 2024 •

edited

Loading

adekbadek left a comment

miguelpeixe left a comment

dkoo commented Aug 1, 2024

matticbot commented Aug 2, 2024

matticbot commented Aug 13, 2024

fix: update dependencies to avoid conflict in WP 6.6 #3181

fix: update dependencies to avoid conflict in WP 6.6 #3181

Conversation

dkoo commented Jun 13, 2024 • edited Loading

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

adekbadek left a comment

Choose a reason for hiding this comment

miguelpeixe left a comment

Choose a reason for hiding this comment

dkoo commented Aug 1, 2024

matticbot commented Aug 2, 2024

matticbot commented Aug 13, 2024

dkoo commented Jun 13, 2024 •

edited

Loading