Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhancements for the Non editing contributor role #3277

Merged
merged 6 commits into from
Aug 1, 2024
Merged

feat: enhancements for the Non editing contributor role #3277

merged 6 commits into from
Aug 1, 2024

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Enhances the Non-Editing Contributor role with a few new features

  • If the user is only under this role, block login and remove some options from their profile

  • remove username and password, woo fields, application password, etc

  • Make email optional

  • Add new UI to add this role to users under other roles

  • Dont allow users with this role to delete their profiles from My Account

How to test the changes in this Pull Request:

  1. Checkout this branch
  2. Add define( 'NEWSPACK_DISABLE_CAP_GUEST_AUTHORS', true ); to wp-config
  3. Visit Users > Guest Authors and see the replacement page
  4. Click "Add new Non-Editing Contributor" and confirm you see the regular form to add a new user but with some modifications (no username, no password)
  5. Create a user and confirm you can assign it as coauthor
  6. Confirm you can not login as this user
  7. Confirm the edit page for this user does not have a bunch of fields (username, password, application password, woo fields, profile colors, etc)
  8. Edit a user under a subscriber-like role
  9. Check the new UI and mark "Allow this user to be assigned as a co-author of a post. " - Save
  10. Login as that user
  11. Confirm you can't delete your account from the My Account page
  12. Confirm you can assign this user as co-author

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner July 25, 2024 18:55
@leogermani leogermani self-assigned this Jul 25, 2024
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 25, 2024
This was referenced Jul 25, 2024
Closed
Closed
Closed
Closed
@adekbadek adekbadek mentioned this pull request Jul 26, 2024
Merged
adekbadek
adekbadek reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a filepath fix and small tweaks in #3278.
Also, a question about assigning dummy emails.
With that question resolved, and the tweaks PR merged in, I'll approve since everything is working well.

assets/other-scripts/co-author-plus/index.js Outdated Show resolved Hide resolved
includes/plugins/class-co-authors-plus.php Show resolved Hide resolved
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 1, 2024
@leogermani leogermani merged commit e47e422 into trunk Aug 1, 2024
8 of 9 checks passed
@adekbadek adekbadek deleted the feat/non-editing-enhacements branch August 1, 2024 10:22
matticbot pushed a commit that referenced this pull request Aug 1, 2024
@semantic-release-bot
chore(release): 4.8.0-alpha.1 [skip ci]
61d7eb0 
# [4.8.0-alpha.1](v4.7.0...v4.8.0-alpha.1) (2024-08-01)

### Bug Fixes

* force active membership if the user has active subs ([#3268](#3268)) ([aebe581](aebe581))
* **woocommerce:** prevent /shop redirect from author archives ([46db669](46db669))

### Features

* enhancements for the Non editing contributor role ([#3277](#3277)) ([e47e422](e47e422))
* **ga4:** filter custom params ([eda5553](eda5553))
* show deprecation warning for CM in Engagement wizard ([#3264](#3264)) ([0813369](0813369))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 13, 2024
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
92b5c87 
# [5.0.0](v4.7.0...v5.0.0) (2024-08-13)

### Bug Fixes

* **data-events:** ensure get_last_successful_order returns WC_Order ([222f58c](222f58c))
* **data-events:** ensure get_last_successful_order returns WC_Order ([#3299](#3299)) ([da21561](da21561))
* **data-events:** race condition between `order_completed` and `subscription_updated` ([#3314](#3314)) ([afbf2e8](afbf2e8))
* force active membership if the user has active subs ([#3268](#3268)) ([aebe581](aebe581))
* namespacing issue ([7b1506a](7b1506a))
* update dependencies to support `@wordpress/scripts` ([#3181](#3181)) ([0d35ac8](0d35ac8))
* **woocommerce:** prevent /shop redirect from author archives ([46db669](46db669))

### Features

* enhancements for the Non editing contributor role ([#3277](#3277)) ([e47e422](e47e422))
* **ga4:** filter custom params ([eda5553](eda5553))
* rename guest contributor role ([#3302](#3302)) ([76ac05e](76ac05e))
* rename guest contributor role ([#3302](#3302)) ([c7f6917](c7f6917))
* show deprecation warning for CM in Engagement wizard ([#3264](#3264)) ([0813369](0813369))

### BREAKING CHANGES

* Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version.

* chore: refactor for updating dependencies in newspack-scripts

* chore: JS formatting fixes for eslint errors

* chore: update NPM scripts and other dependencies

* chore: fix jest unit tests

* chore: update dependencies in newspack-components

* fix: peer dependency conflicts with @wordp
ress/* packages

* chore: update newspack-components dependencies

* chore: proxy stylelint from newspack-scripts

* chore: remove unnecessary stylelint

* refactor: use proxy script for eslint and stylelint scripts

* chore: remove console.log

* chore: update newspack-scripts to NPM alpha version

* chore: update newspack-scripts to git branch

* chore: update newspack-scripts to alpha.3

* test: remove unneeded mocks

* deps: newspack-scripts@5.6.0-alpha.1

* chore: fix scripts

* fix: update newspack-scripts to v5.6.0-alpha.2

* fix: add newspack-revisions.js to webpack build for linting

* fix: update stylelint and format CSS for errors

* chore: clear TS check errors

* fix: start command

* fix: remove i18n script (Blocks only)

* temporarily revert stylelint autoformat to avoid merge conflicts

* chore: add .stylelintrc.js

* fix: reformat SCSS

* chore: update newspack-scripts to v5.6.0-alpha.4

* fix: add missing Prettier config files

* chore: update newspack-scripts to 5.6.0-alpha.5

* chore: update newspack-scripts to v5.6.0-alpha.7

* style: stylelint autofixes

* fix: add fix:js script; temporarily remove format:js

* fix: update newspack-scripts to v5.5.0-alpha.8 and restore format:js script

* chore: add NPM scripts for PHP

* refactor: move recaptcha JS to src directory

* fix: ignore dist and node_modules inside src/components, too

* fix: update Babel configs for components

* fix(components): output TS and JS, and publish new major version to NPM

* fix: do not delete node_modules after post-publish

* chore: bump newspack-scripts to v5.5.2
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adekbadek adekbadek mentioned this pull request Aug 20, 2024
Merged
6 tasks
@adekbadek adekbadek mentioned this pull request Aug 29, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @adekbadek