Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guest-author): enqueue the guest author admin script selectively #3351

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The guest author script (#3277) should only be enqueued where applicable.

How to test the changes in this Pull Request:

  1. On trunk, observe the newspack-plugin/dist/other-scripts/co-authors-plus.js JS script is loaded for any admin request (e.g. editor)
  2. Switch to this branch, observe it's not anymore
  3. Add or edit a user - observe the script is included there

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 20, 2024
@adekbadek adekbadek requested a review from a team as a code owner August 20, 2024 10:31
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 21, 2024
@adekbadek adekbadek merged commit 0bf37af into trunk Aug 22, 2024
9 checks passed
@adekbadek adekbadek deleted the fix/guest-author-script branch August 22, 2024 06:37
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants