Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a UI to add the non editing contrib role #3255

Closed
wants to merge 1 commit into from

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jul 17, 2024

All Submissions:

Changes proposed in this Pull Request:

Adds a UI to assign users to the custom Non-Editing Contributor role:

image

How to test the changes in this Pull Request:

  1. Edit a user
  2. See the new "Co-Authors Plus" section
  3. Check the box to add the custom role save
  4. Confirm the role is added to the user
  5. Uncheck the box and save
  6. Confirm the role is removed
  7. Confirm you don't see this section when you edit your own profile

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani requested a review from a team as a code owner July 17, 2024 16:13
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much better than having to recommend a multi-user-role plugin.

@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Jul 19, 2024
@leogermani
Copy link
Contributor Author

closed in favor of #3277 See pemhSX-Sz-p2

@leogermani leogermani closed this Jul 25, 2024
@leogermani leogermani deleted the add/non-editing-contrib-ui branch July 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants