Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove check for default meta values that isn’t working #235

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: remove check for default meta values that isn’t working #235

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
834e9ea
fix: remove check for default meta values that isn’t working
dkoo Mar 15, 2023
1228957
Merge branch 'master' into fix/remove-nonfunctional-check
dkoo Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions includes/class-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public static function register_meta() {
[
'description' => __( 'Display the sponsor only in the byline, or both the sponsor and post author.', 'newspack-sponsors' ),
'type' => 'string',
'default' => self::is_sponsor() ? 'sponsor' : 'inherit',
'default' => 'inherit',
'sanitize_callback' => 'sanitize_text_field',
'single' => true,
'show_in_rest' => true,
Expand All @@ -253,7 +253,7 @@ public static function register_meta() {
[
'description' => __( 'Display the sponsor only, or display categories alongside the sponsor.', 'newspack-sponsors' ),
'type' => 'string',
'default' => self::is_sponsor() ? 'sponsor' : 'inherit',
'default' => 'inherit',
'sanitize_callback' => 'sanitize_text_field',
'single' => true,
'show_in_rest' => true,
Expand All @@ -268,7 +268,7 @@ public static function register_meta() {
[
'description' => __( 'Display the underwriter blurb in standard or simple-text format.', 'newspack-sponsors' ),
'type' => 'string',
'default' => self::is_sponsor() ? 'standard' : 'inherit',
'default' => 'inherit',
'sanitize_callback' => 'sanitize_text_field',
'single' => true,
'show_in_rest' => true,
Expand All @@ -283,7 +283,7 @@ public static function register_meta() {
[
'description' => __( 'Display the underwriter blurb at the top or bottom of the post.', 'newspack-sponsors' ),
'type' => 'string',
'default' => self::is_sponsor() ? 'top' : 'inherit',
'default' => 'inherit',
'sanitize_callback' => 'sanitize_text_field',
'single' => true,
'show_in_rest' => true,
Expand Down