fix: remove check for default meta values that isn’t working #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Could be a chore, too, because it doesn't change any behavior in the plugin. But it removes a check and condition that isn't working. Because
register_meta
is happening on theinit
hook, it's too early to determine the post type, so the default values for several meta fields are alwaysinherit
. This PR makes this explicit.Related to Automattic/newspack-theme#2061 but isn't a blocker to that PR.
How to test the changes in this Pull Request:
Nothing really to test—you can confirm that
get_post_meta
with the following fields always returnsinherit
by default:newspack_sponsor_sponsorship_scope
newspack_sponsor_native_byline_display
newspack_sponsor_underwriter_style
newspack_sponsor_underwriter_placement
Other information: