-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display underwriters with default placement value #2061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @dkoo! 🙌
Confirmed that the updates fixed the issue, and also that the sponsor settings are still being applied properly (changing the settings on the sponsor level, and on the per-post level, both work!).
🎉 This PR is included in version 1.69.4-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.69.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Fixes an issue with default sponsor meta values. The default values for several meta fields is
inherit
, but the theme expects them to be something else, which causes some issues with display when defaults are used. This mainly affects the display of underwriter-type sponsors when no post-level overrides are set.Closes
1200550061930446/1204158091646412
How to test the changes in this Pull Request:
master
, publish a new sponsor with a title and some content and set the scope to Underwritten Content. Leave everything else default/blank.Other information: