-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure wide blocks don't overflow containers #2063
Conversation
I think this could use a review from someone with more experience with editor as well. From what I've seen, this fixes the layout issues when testing the same content on I'm not sure what's the expected behavior, but for Full width groups, they are always full width no matter which page template I choose. I noticed that the image captions are misaligned when they are too wide: |
Thanks @leogermani! Totally understand -- it's A Lot to verify. Even if you're not 100% sure about it, though, the extra eyes are a huge help!
This is correct for the One Column & One Column Wide templates! The full-width blocks should be hitting the edge of the browser window; the wide blocks should be somewhere in between, and are narrower when the content is narrower (so they're not quite as wide in the One Column template as they are in the One Column Wide template). The only template you shouldn't see this with is the default template with the sidebar, which wasn't part of the testing steps so hopefully that's not where you're still seeing the full-width groups 😅
Ah, that's a good catch! This is kind of intentional, so when you have a wide or full width image stacked on top of paragraphs of content, the caption lines up with the width of the content and isn't sitting so far to the left and right. Like this: ... but it seems weird when you see it nested inside of other blocks, especially inside of a column like in your screenshot, where it doesn't line up with the normal width blocks. I'm going to revisit that in the meantime and at least get the widths more consistent in columns! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since I don't see anything broken and it fixes the issue
Thanks @leogermani! |
🎉 This PR is included in version 1.69.4-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.69.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR fixes some too-wide wide block issues that were introduced in #2047 -- prior to that change, wide blocks nested inside of narrower group or columns blocks would stay inside of them, but afterwards they'd overflow. This doesn't line up with the editor preview, and caused some unexpected display issues!
This PR should really just address edge cases, hopefully without introducing any new fun problems 😬 I tried being as thorough as possible with my testing and I've included my test content below as a starting point, but please add to it any horrible block nesting decisions you can think of... and logical ones, too!
Testing code!
How to test the changes in this Pull Request:
Screenshots to illustrate the difference in widths of nested blocks in Group blocks vs. Columns blocks
Group blocks (regular, wide, full-width) - the inner block's max width should be 1200px, unless they're wide or full width
One column columns block - the inner block's max width should be 100%, regardless of their width settings - this looks a little strange with one column like this, compared to the group block, but I think makes more sense than an inner block being narrower than a really wide column.
Other information: