Revert default player audio callback (#2521)

Automattic · Dec 9, 2024 · f511534 · f511534
2 parents 609b196 + ea7f76f
commit f511534
Showing 1 changed file with 17 additions and 13 deletions.
diff --git a/podcasts/DefaultPlayer.swift b/podcasts/DefaultPlayer.swift
@@ -455,15 +455,18 @@ class DefaultPlayer: PlaybackProtocol, Hashable {
         }
 
         let peakLimiterRenderCallback: AURenderCallback = { inRefCon, _, _, _, inNumberFrames, ioData -> OSStatus in
-            guard
-                let referenceToSelf = DefaultPlayer.unretainedDefaultPlayer(for: inRefCon),
-                let ioData,
-                let tap = referenceToSelf.audioMix?.inputParameters.first?.audioTapProcessor
-            else {
-                return -1
+            if ioData == nil { return -1 }
+            let referenceToSelf: DefaultPlayer
+            if FeatureFlag.defaultPlayerFilterCallbackFix.enabled {
+                let reference = Unmanaged<DefaultPlayer>.fromOpaque(inRefCon)
+                referenceToSelf = reference.takeUnretainedValue()
+            } else {
+                referenceToSelf = unsafeBitCast(inRefCon, to: DefaultPlayer.self)
             }
+            guard let tap = referenceToSelf.audioMix?.inputParameters.first?.audioTapProcessor else { return -1 }
+
             // The peak limiter is at the end of the chain so just grab the processed audio
-            return MTAudioProcessingTapGetSourceAudio(tap, CMItemCount(inNumberFrames), ioData, nil, nil, nil)
+            return MTAudioProcessingTapGetSourceAudio(tap, CMItemCount(inNumberFrames), ioData!, nil, nil, nil)
         }
 
         // MARK: - High Pass Filter
@@ -505,13 +508,14 @@ class DefaultPlayer: PlaybackProtocol, Hashable {
         }
 
         let highPassFilterRenderCallback: AURenderCallback = { inRefCon, _, inTimeStamp, _, inNumberFrames, ioData -> OSStatus in
-            guard
-                let referenceToSelf = DefaultPlayer.unretainedDefaultPlayer(for: inRefCon),
-                let peakLimiter = referenceToSelf.peakLimiter,
-                let ioData = ioData
-            else {
-                return -1
+            let referenceToSelf: DefaultPlayer
+            if FeatureFlag.defaultPlayerFilterCallbackFix.enabled {
+                let reference = Unmanaged<DefaultPlayer>.fromOpaque(inRefCon)
+                referenceToSelf = reference.takeUnretainedValue()
+            } else {
+                referenceToSelf = unsafeBitCast(inRefCon, to: DefaultPlayer.self)
             }
+            guard let peakLimiter = referenceToSelf.peakLimiter, let ioData = ioData else { return -1 }
 
             var audioTimeStamp = AudioTimeStamp()
             audioTimeStamp.mSampleTime = inTimeStamp.pointee.mSampleTime