Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert default player audio callback #2521

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Revert default player audio callback #2521

merged 1 commit into from
Dec 9, 2024

Conversation

danielebogo
Copy link
Contributor

Temporary revert of #2495

We need to check all the Unretained passed to all callback otherwise it will crash while unwrapping it.

To test

  • CI must be 🟢
  • Run this branch and play an episode with the volume boost on
  • Confirm the app won't crash

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Bug Used for issues where something is not functioning as intended. label Dec 9, 2024
@danielebogo danielebogo added this to the 7.79 milestone Dec 9, 2024
@danielebogo danielebogo requested a review from a team as a code owner December 9, 2024 09:38
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.79. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

SergioEstevao
SergioEstevao approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on simulator and device and working correctly.
:shipit:

@danielebogo danielebogo merged commit f511534 into trunk Dec 9, 2024
6 of 8 checks passed
@danielebogo danielebogo deleted the danieleb/revert-default-player-audio-callback branch December 9, 2024 10:01
@danielebogo danielebogo mentioned this pull request Dec 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.79 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@danielebogo @dangermattic @SergioEstevao