Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FF for episodeArtwork #2535

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove FF for episodeArtwork #2535

merged 1 commit into from
Dec 11, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Dec 11, 2024 •
edited
Loading

| 📘 Part of: #2509 |
|:---:|

Fixes #2531

1 2
Simulator Screenshot - iPhone 16 Pro - 2024-12-11 at 14 31 47 Simulator Screenshot - iPhone 16 Pro - 2024-12-11 at 14 32 16

To test

  • Start the app
  • Go to Profile -> Settings -> Appearance
  • On the section Podcast Artwork ensure that you have Use Episode Artwork is enabled
  • Go to Discover
  • Search for the following podcast: The Daily
  • Play an episode
  • Open the full screen player
  • Check if the episode artwork is show on top center

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.80 milestone Dec 11, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Base automatically changed from remove/ff_new_show_notes_endpoints to trunk December 11, 2024 14:06
@SergioEstevao SergioEstevao marked this pull request as ready for review December 11, 2024 14:32
@SergioEstevao SergioEstevao requested a review from a team as a code owner December 11, 2024 14:32
@SergioEstevao SergioEstevao requested review from leandroalonso and removed request for a team December 11, 2024 14:32
@SergioEstevao SergioEstevao merged commit 17a4790 into trunk Dec 11, 2024
6 of 8 checks passed
@SergioEstevao SergioEstevao deleted the remove/ff_episodeFeedArtwork branch December 11, 2024 21:17
@SergioEstevao SergioEstevao mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

Assignees
No one assigned
Labels
Feature Flag
Projects
None yet
Milestone
7.80
Development

Successfully merging this pull request may close these issues.

Remove episodeFeedArtwork
3 participants
@SergioEstevao @dangermattic @leandroalonso