Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FF for episodeArtwork #2535

Merged
merged 1 commit into from
Dec 11, 2024
+0 −11
Merged

Remove FF for episodeArtwork #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ public enum FeatureFlag: String, CaseIterable {
/// Whether End Of Year feature is enabled
case endOfYear

/// Enable retrieving episode artwork from the RSS feed
case episodeFeedArtwork

/// Enable chapters to be loaded from the RSS feed
case rssChapters

Expand Down Expand Up @@ -161,8 +158,6 @@ public enum FeatureFlag: String, CaseIterable {
false
case .endOfYear:
false
case .episodeFeedArtwork:
false
case .rssChapters:
false
case .errorLogoutHandling:
Expand Down Expand Up @@ -258,8 +253,6 @@ public enum FeatureFlag: String, CaseIterable {
shouldEnableSyncedSettings ? "new_settings_storage" : nil
case .settingsSync:
shouldEnableSyncedSettings ? "settings_sync" : nil
case .episodeFeedArtwork:
"episode_artwork"
case .rssChapters:
"rss_chapters"
case .categoriesRedesign:
Expand Down
4 changes: 0 additions & 4 deletions podcasts/EpisodeArtwork.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ class EpisodeArtwork {
}

private func loadEpisodeArtworkFromUrl(podcastUuid: String, episodeUuid: String) {
guard FeatureFlag.episodeFeedArtwork.enabled else {
return
}

Task { [weak self] in
guard let self else {
return
Expand Down