Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Links: Wires new Endpoints #1612

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Magic Links: Wires new Endpoints #1612

merged 5 commits into from
Jul 15, 2024

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 11, 2024 •
edited
Loading

⚠️ Important

  • Make sure the new endpoints are deployed before merging
  • Remove the staging URL!

Fix

In this PR we're wiring the new code-based endpoints.

Ref. #1611

Test

  1. Logout from Simplenote macOS
  2. Click on the Log In button
  3. Enter your email
  4. Click on Instantly Log In with Email
  • Verify that shortly after you get the Auth Email
  • Verify that clicking on Log Into Simplenote button causes the mac app to Log In

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the enhancement Improve existing functionality. label Jul 11, 2024
@jleandroperez jleandroperez added this to the 4.52 milestone Jul 11, 2024
@jleandroperez jleandroperez self-assigned this Jul 11, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 11, 2024 •
edited
Loading

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1612-9507731-0190b7ee-0235-480f-8764-dcfaac7b41cc on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jleandroperez jleandroperez marked this pull request as ready for review July 11, 2024 17:30
roundhill
roundhill approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked! Your instructions said Mac app but I assume that was copy-pasta error :)

@jleandroperez
Copy link
Contributor Author

Thank you both!!

@jleandroperez jleandroperez merged commit 94f66ad into trunk Jul 15, 2024
8 of 11 checks passed
@jleandroperez jleandroperez deleted the lantean/1611-updates-magic-link-endpoints branch July 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roundhill roundhill roundhill approved these changes

@charliescheer charliescheer charliescheer approved these changes

Assignees

@jleandroperez jleandroperez

Labels
enhancement Improve existing functionality.
Projects
None yet
Milestone
4.52 ❄️
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jleandroperez @wpmobilebot @roundhill @charliescheer