Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: Switch to Code Authentication #1611

Closed
9 tasks done
jleandroperez opened this issue Jul 11, 2024 · 1 comment · Fixed by #1619
Closed
9 tasks done

Magic Links: Switch to Code Authentication #1611

jleandroperez opened this issue Jul 11, 2024 · 1 comment · Fixed by #1619
Assignees
Labels
enhancement Improve existing functionality.
Milestone

Comments

@jleandroperez
Copy link
Contributor

jleandroperez commented Jul 11, 2024

Details:

  • Wire the new code-based endpoints
  • Update the Magic Link Handler so that it manages the new parameters
  • Implement a new flow that would allow users to type the code
  • Code UI requires a header
  • Verify the Invalid Token UI is still triggered
  • Verify the Magic Link Flow is still supported
  • Improve Error Handling: 429 / Request Code directly in the Code UI?
  • Fix Unit Tests
  • Return nil when fields are empty

Mockups

@jleandroperez jleandroperez added the bug Something isn't working. label Jul 11, 2024
@jleandroperez jleandroperez self-assigned this Jul 11, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 11, 2024

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants