Login Flow: Splitting Username / Password Interfaces #1614
Conversation
Generated by 🚫 Danger |
|
You can test the changes in simplenote-ios from this Pull Request by:
|
| let backButton = app.navigationBars[UID.NavBar.logIn].buttons.element(boundBy: 0) | ||
| if backButton.isHittable { | ||
| backButton.tap() | ||
| } |
There was a problem hiding this comment.
We account for the fact that the Auth Flow may be multi-layered
| EmailLogin.logIn(email: "", password: "") | ||
| app.assertLabelExists(withText: Text.loginEmailInvalid) | ||
| app.assertLabelExists(withText: Text.loginPasswordShort) | ||
| } |
There was a problem hiding this comment.
This test is no longer relevant: Email + Password never show up simultaneously
jleandroperez
changed the title
| if mode.isUsernameHidden { | ||
| return .success | ||
| } |
There was a problem hiding this comment.
This feels a little odd to me. It may be nit picky, but if you are performing a username validation and the username is hidden, should we be returning success?
| func performPasswordValidation() -> AuthenticationValidator.Result { | ||
| guard !mode.isPasswordHidden else { | ||
| if mode.isPasswordHidden { | ||
| return .success |
There was a problem hiding this comment.
Same comment as above, maybe the validator result should be able to return a not needed?
|
@charliescheer I'll switch the Changing things here will break something down the line, and it'll be waaaay easier to patch in a standalone. Thank youuu!! |
Details:
Our new Authentication UX involves a multi staged flow, where Username and Password aren't necessarily entered in the same UI.
In this PR we're updating
SPAuthViewControlleras follows:AuthenticationModehas been enhanced, to support new fieldsAuthenticationModecan no longer be modified, which helps us drop several methodsAuthenticationState, which allows us to pass on the State across different screensPlus the Onboarding UI no longer displays a sheet when you tap
Log In.Ref. #1611
Test
Log InLog in with emailbutton turns blueForgot your Passwordopens the PW recovery websiteLog in, you get authenticatedTest: WPCOM SSO
Log InLog in with WordPress.comRelease
RELEASE-NOTES.txtwas updated in 05869f2 with