Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Links: Handling 429 #1618

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Magic Links: Handling 429 #1618

merged 12 commits into from
Jul 17, 2024

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 16, 2024 •
edited by charliescheer
Loading

Fix

In this PR we're handling the .tooManyAttempts error, when requesting a Login Code.

Ref. #1611

Test

  1. Fresh install Simplenote
  2. Press on the Log In button
  3. Enter your email
  4. Press on Log in with email
  5. Go back
  6. Repeat steps 4 and 5 until you get an alert
  • Verify that after 10x attempts, Simplenote goes from Email > Password (skipping the Code UI)
  • Verify that the Password UI has a header, indicating that the Code Request failed

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the enhancement Improve existing functionality. label Jul 16, 2024
@jleandroperez jleandroperez added this to the 4.52 milestone Jul 16, 2024
@jleandroperez jleandroperez self-assigned this Jul 16, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 16, 2024 •
edited
Loading

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1618-5b84e8e-0190bdb0-4368-45ac-80dc-b5270f4392e6 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jleandroperez jleandroperez marked this pull request as ready for review July 16, 2024 21:14
charliescheer
charliescheer approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@charliescheer charliescheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@jleandroperez
Copy link
Contributor Author

Thank youuu!!

@jleandroperez jleandroperez merged commit e2dad4b into trunk Jul 17, 2024
12 of 13 checks passed
@jleandroperez jleandroperez deleted the lantean/1611-handling-error-429 branch July 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliescheer charliescheer charliescheer approved these changes

@roundhill roundhill Awaiting requested review from roundhill

Assignees

@jleandroperez jleandroperez

Labels
enhancement Improve existing functionality.
Projects
None yet
Milestone
4.52
Development

Successfully merging this pull request may close these issues.
3 participants
@jleandroperez @wpmobilebot @charliescheer