Login: Addressing Debt

[jleandroperez]

Fix

In this PR we're updating the way Validation works, so that we no longer return .success for fields that aren't even visible.

Closes #1611

Thank you @charliescheer !!

Test: Signup

1. Fresh install Simplenote
2. Press on Signup

• Verify that if you press the Sign Up button a warning shows up
• Verify that if you enter a valid email, the warning disappears, and the Sign Up action becomes blue

Test: Login with Code

1. Fresh install Simplenote
2. Press on Log in

• Verify that if you press the Log in with email button, a warning shows up
• Verify that entering a valid email causes the warning to disappear
• Verify that the Code UI displays a warning, if you press Log in without entering the code
• Verify that entering the correct code logs you in

Test: Login with Password

1. Fresh install Simplenote
2. Press on Log in
3. Enter your email
4. Press on Log in with email
5. Press on Enter password

• Verify that pressing Log In, without entering a password, causes a warning to appear
• Verify that if you enter the correct password, you get logged in

Release

These changes do not require release notes.

[wpmobilebot]

You can test the changes in simplenote-ios from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr1619-53b3ea6-0190c105-bde1-4398-9a32-9254d3ba12db on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[charliescheer]

👨‍🍳 💋

[jleandroperez]

Thank you Charlie!!