Login: Auth Code Interface #1615
Conversation
Generated by 🚫 Danger |
|
You can test the changes in simplenote-ios from this Pull Request by:
|
| return false | ||
| } | ||
| } | ||
|
|
||
|
|
||
| // MARK: - State |
There was a problem hiding this comment.
All of the structs below have been extracted + simplified into AuthenticationMode
| @@ -850,50 +850,6 @@ private enum PasswordInsecureString { | |||
| } | |||
|
|
|||
|
|
|||
| // MARK: - Mode: .loginWithPassword | |||
| // | |||
| private enum PasswordStrings { | |||
There was a problem hiding this comment.
Same note as above: extracted into AuthenticationMode
| break | ||
| } | ||
|
|
||
| performPrimaryActionIfPossible() |
There was a problem hiding this comment.
performPrimaryActionIfPossible is now responsible for rendering Warnings, when / if needed.
Plus we'll never show Username + Password fields, at once, so we're simplifying this
| @@ -662,6 +756,7 @@ private extension SPAuthViewController { | |||
| func ensureWarningsAreOnScreenWhenNeeded() -> Bool { | |||
| let usernameValidationResult = performUsernameValidation() | |||
| let passwordValidationResult = performPasswordValidation() | |||
| let codeValidationResult = performCodeValidation() | |||
There was a problem hiding this comment.
Extending pre-existant validation mechanisms, to check for the Code as well
| SPTracker.trackLoginLinkConfirmationFailure() | ||
| self.handleError(error: error) | ||
| } catch { | ||
| // TODO: Fixme |
There was a problem hiding this comment.
To be revisited in a follow up:
- I'm not fond of not having typed errors
- I think rate limited responses should be handled in a specific way (ie. pushing the Password UI)
| lockdownInterface() | ||
|
|
||
| controller.requestLoginEmail(username: email) { error in | ||
| // TODO: 429 (Rate Limited)? push PW auth instead |
There was a problem hiding this comment.
To be handled in a follow up. Rate limiting errors should prob. cause the Password UI to show up
| @@ -332,16 +381,21 @@ private extension SPAuthViewController { | |||
|
|
|||
| // MARK: - Actions | |||
| // | |||
| private extension SPAuthViewController { | |||
| extension SPAuthViewController { | |||
There was a problem hiding this comment.
Removing private since the AuthenticationMode descriptors live in its own file
|
|
||
| actionView.addTarget(self, action: descriptor.selector, for: .touchUpInside) | ||
| actionView.isHidden = false | ||
| } |
There was a problem hiding this comment.
Ideally we don't have 4x Actions, and use them accordingly. Instead, we should simply instantiate the UIButton instances, based on the descriptor.
I'm keeping the changeset delta on check, though, and following along. For now!
|
|
||
| /// # Primary Action: LogIn / SignUp | ||
| /// | ||
| @IBOutlet private var primaryActionButton: SPSquaredButton! { | ||
| didSet { | ||
| primaryActionButton.setTitle(mode.primaryActionText, for: .normal) |
There was a problem hiding this comment.
Most of the UI initialization code that was deleted here, will be handled by the new API(s) refreshActionViews and reloadInputViewsFromState.
jleandroperez
changed the title
|
|
||
| return usernameValidationResult == .success && passwordValidationResult == .success | ||
| return usernameValidationResult == .success && passwordValidationResult == .success && codeValidationResult == .success |
There was a problem hiding this comment.
This is duplicated in L192. Should it be extracted somewhere?
|
Yeahhhh I'm tempted to just start splitting (or even going SwiftUI), but with this approach we can add or remove things in a split second. Adding Passkeys should take a minute, now? Thank you Charlie!! |
Details
In this PR we're:
AuthenticationModeinto its own fileAuthViewControllerinitialization, so that it uses dynamic descriptorsCodefieldRef. #1611
Test: Login with Code
Log InLog in with emailTest: Login with Password
Log InLog in with emailEnter PasswordLog Ingets you a warning onscreenTest: Login with WP
Log InLog in with WordPress.comTest: Signup
SignupSign Upwithout entering a valid email gets you a warning onscreenRelease