-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login: Code Header #1617
Login: Code Header #1617
Conversation
Generated by 🚫 Danger |
You can test the changes in simplenote-ios from this Pull Request by:
|
@@ -60,7 +60,7 @@ private extension MagicLinkAuthenticator { | |||
NSLog("[MagicLinkAuthenticator] Requesting SyncToken for \(email) and \(authCode)") | |||
NotificationCenter.default.post(name: .magicLinkAuthWillStart, object: nil) | |||
|
|||
Task { | |||
Task { @MainActor in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing a threading violation
@@ -221,7 +221,7 @@ private extension SPOnboardingViewController { | |||
hostingController.modalPresentationStyle = .formSheet | |||
hostingController.sheetPresentationController?.detents = [.medium()] | |||
|
|||
let presenter = presentedViewController ?? self | |||
let presenter = navigationController?.visibleViewController ?? self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since now we may have multiple VCs in the hierarchy, we must access the UINavigationController
Thank youuuu |
Fix
In this PR we're building a Haeader in the Authentication Code UI.
Ref. #1611
Scenario: Auth
Log in
Log in with your email
Scenario: Invalid Link
Log in
Request a new Link
gets you back into the Login UIRelease