Login: Code Header #1617
Merged
Login: Code Header #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
You can test the changes in simplenote-ios from this Pull Request by:
|
jleandroperez
commented
Jul 15, 2024
| @@ -60,7 +60,7 @@ private extension MagicLinkAuthenticator { | |||
| NSLog("[MagicLinkAuthenticator] Requesting SyncToken for \(email) and \(authCode)") | |||
| NotificationCenter.default.post(name: .magicLinkAuthWillStart, object: nil) | |||
|
|
|||
| Task { | |||
| Task { @MainActor in | |||
There was a problem hiding this comment.
This was causing a threading violation
jleandroperez
commented
Jul 15, 2024
| @@ -221,7 +221,7 @@ private extension SPOnboardingViewController { | |||
| hostingController.modalPresentationStyle = .formSheet | |||
| hostingController.sheetPresentationController?.detents = [.medium()] | |||
|
|
|||
| let presenter = presentedViewController ?? self | |||
| let presenter = navigationController?.visibleViewController ?? self | |||
There was a problem hiding this comment.
Since now we may have multiple VCs in the hierarchy, we must access the UINavigationController
charliescheer
approved these changes
Jul 16, 2024
|
Thank youuuu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR we're building a Haeader in the Authentication Code UI.
Ref. #1611
Scenario: Auth
Log inLog in with your emailScenario: Invalid Link
Log inRequest a new Linkgets you back into the Login UIRelease