Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display issue for checked radio button on Rates Step #2279

Closed
bborman22 opened this issue Dec 8, 2020 · 0 comments · Fixed by #2303
Closed

Display issue for checked radio button on Rates Step #2279

bborman22 opened this issue Dec 8, 2020 · 0 comments · Fixed by #2303
Assignees
@waclawjacek
Labels
[Pri] High [Type] Bug

Comments

@bborman22
Copy link
Contributor

When selecting a shipping rate from the Create Shipping Label model, the pink dot to signify the checked radio button is off center with the radio button outline. This issue appears to have been introduced with updating WooCommerce to version 4.8.

Off Center Radio Button

Steps to Reproduce

  1. Confirm you are using WooCommerce version 4.8.
  2. Set up the WCS&T plugin.
  3. Place an order that can be shipped.
  4. Go to create shipping label for the order.
  5. Select a rate from the list in the Select Rate step of the Create Shipping Label modal.
  6. Notice that on the Select Rate step the dot indicating a selected radio button is off-center.
@frosso frosso mentioned this issue Jan 5, 2021
Merged
waclawjacek added a commit that referenced this issue Jan 18, 2021
@waclawjacek
Fix off-center radio button on Rates Step (#2279)
1ad991b 
Due to an update in @wordpress/base-styles used by WooCommerce Admin,
the dots in WCS&T's radio buttons were no longer centered:
WordPress/gutenberg#23706

This is now fixed and support for high contrast mode in Windows
is added in alignment with the aforementioned PR.
@waclawjacek waclawjacek mentioned this issue Jan 19, 2021
Merged
2 tasks
@frosso frosso mentioned this issue Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waclawjacek waclawjacek

Labels
[Pri] High [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix radio button dot alignment in "Create shipping label" Automattic/woocommerce-services
3 participants
@waclawjacek @c-shultz @bborman22