Fix radio button dot alignment in "Create shipping label" #2303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a change introduced in
@wordpress/base-styles
to support high contrast mode on Windows that the styles in WCS&T are not compatible with.How to reproduce:
git checkout 4.8.0 && npm install && composer install && npm run build
@wordpress/base-styles
was upgraded:git checkout c27e266051d4fc72b1e7fb87b2c4ac365d629cef && composer install && npm install && npm run build
cp woocommerce-admin/dist/app/style.css woocommerce/packages/woocommerce-admin/dist/app/style.css
git checkout HEAD~1 && npm install && npm run build
cp woocommerce-admin/dist/app/style.css woocommerce/packages/woocommerce-admin/dist/app/style.css
This PR fixes the off-center dots in the Create shipping label modal and improves styles in high contrast mode on Windows.
I have tested the solution on WooCommerce 4.7.0, 4.8.0, and the current
master
(5.0.0-dev).Related issue(s)
Fixes #2279
Steps to reproduce & screenshots/GIFs
All screenshots were taken in Firefox on Windows 10.
Before:
Before in high contrast mode:
After:
After in high contrast mode:
Checklist
changelog.txt
entry added