Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase: Move all page titles into one place #1030

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 30, 2015

Part of #275.

This PR includes also import statements update. I sorted them by name.

Testing

  1. Open http://calypso.localhost:3000/purchases.
  2. Navigate through all subpages. All titles should look the same in browser bar and in page header.

@gziolo gziolo added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 30, 2015
@gziolo gziolo self-assigned this Nov 30, 2015
@gziolo gziolo added this to the Purchases: v2 milestone Nov 30, 2015
@gziolo gziolo added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 30, 2015
@gziolo gziolo force-pushed the update/purchases-page-skeletons branch from cc062fc to 5df1e40 Compare November 30, 2015 12:19
import Card from 'components/card';
import Main from 'components/main';
import { isRefundable } from 'lib/purchases';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you are reordering alphabetically, i < h.

@scruffian
Copy link
Member

👍

Some minor a-z issues, but LGTM 🚢

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 30, 2015
@gziolo gziolo force-pushed the update/purchases-page-skeletons branch from 5df1e40 to e40cd8d Compare November 30, 2015 12:37
gziolo added a commit that referenced this pull request Nov 30, 2015
Purchase: Move all page titles into one place
@gziolo gziolo merged commit 18ba580 into master Nov 30, 2015
@gziolo gziolo deleted the update/purchases-page-skeletons branch November 30, 2015 12:49
@fabianapsimoes fabianapsimoes removed this from the Purchases: v2 milestone Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants