Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Add loading page skeleton for Single Purchase pages #275

Closed
10 of 12 tasks
fabianapsimoes opened this issue Nov 20, 2015 · 10 comments
Closed
10 of 12 tasks

Purchases: Add loading page skeleton for Single Purchase pages #275

fabianapsimoes opened this issue Nov 20, 2015 · 10 comments
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task

Comments

@fabianapsimoes
Copy link
Contributor

We need design for Purchase pages loading state. This includes following pages:

As part of this task we should also add redirects for all aforementioned pages when there is no purchase selected.

Loading Placeholders

@mikeshelton1503 proposed the following mockups:

Page Redirects

Refactoring tasks

@fabianapsimoes fabianapsimoes added [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 20, 2015
@fabianapsimoes fabianapsimoes added this to the Purchases: v1 milestone Nov 20, 2015
@gziolo gziolo self-assigned this Nov 24, 2015
@gziolo
Copy link
Member

gziolo commented Nov 25, 2015

Manage Purchase page needs some improvements on mobile view:
manage-purchase

@fabianapsimoes
Copy link
Contributor Author

Manage Purchase page needs some improvements on mobile view:

That's being fixed in #670.

@drewblaisdell drewblaisdell added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 25, 2015
@scruffian scruffian added [Status] Needs Author Reply [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Author Reply labels Nov 26, 2015
@gziolo gziolo reopened this Nov 26, 2015
@gziolo
Copy link
Member

gziolo commented Nov 26, 2015

Page skeleton for Edit Payment Method page moved to #843.

@gziolo
Copy link
Member

gziolo commented Nov 30, 2015

@scruffian I was trying to accomplish refactoring: Create Edit Card Details skeleton that can be shared by loading placeholder and page component.
I ended up producing more lines of code, than using duplicated HTML code in case of Edit Card Details page, let's skip it for the time being. Feel free to revisit it in the future. I hope you can come up with some nice optimisation :)

@scruffian
Copy link
Member

@gziolo IMO its worth having more lines to reduce duplication. I anticipate people forgetting to update skeletons in the future when they update a page...

@gziolo
Copy link
Member

gziolo commented Dec 2, 2015

This is still work in progress. All loading placeholders are done. I started working on handling page redirects when there are cases like:

  • purchase was removed but we try to access page using old url
  • we enter the page that shouldn't be loaded for the given purchase

I'm not quite sure how we should handle the case when site's domain has changed, and user tries to load purchase page with old url. Sites list returns no data at the moment causing issues in placeholders.

@fabianapsimoes I think it'd be good to revisit if we want to implement those redirects in v1.

@fabianapsimoes
Copy link
Contributor Author

@gziolo could you open a new issue describing this issue? Then we can discuss it and prioritize in a different thread.

@gziolo
Copy link
Member

gziolo commented Dec 9, 2015

@fabianapsimoes: issue created: #1407, I don't think it's very important, but it would be nice to find solution for this edge case.

@fabianapsimoes fabianapsimoes modified the milestones: Amber: Backlog, Purchases: v1 Jan 13, 2016
@fabianapsimoes
Copy link
Contributor Author

I've reported the missing page redirects in this issue in #2519. Closing this issue.

@gziolo
Copy link
Member

gziolo commented Jan 18, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task
Projects
None yet
Development

No branches or pull requests

4 participants