-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add loading page skeleton for Single Purchase pages #275
Comments
That's being fixed in #670. |
Page skeleton for Edit Payment Method page moved to #843. |
@scruffian I was trying to accomplish refactoring: |
@gziolo IMO its worth having more lines to reduce duplication. I anticipate people forgetting to update skeletons in the future when they update a page... |
This is still work in progress. All loading placeholders are done. I started working on handling page redirects when there are cases like:
I'm not quite sure how we should handle the case when site's domain has changed, and user tries to load purchase page with old url. Sites list returns no data at the moment causing issues in placeholders. @fabianapsimoes I think it'd be good to revisit if we want to implement those redirects in v1. |
@gziolo could you open a new issue describing this issue? Then we can discuss it and prioritize in a different thread. |
@fabianapsimoes: issue created: #1407, I don't think it's very important, but it would be nice to find solution for this edge case. |
I've reported the missing page redirects in this issue in #2519. Closing this issue. |
👍 |
We need design for Purchase pages loading state. This includes following pages:
As part of this task we should also add redirects for all aforementioned pages when there is no purchase selected.
Loading Placeholders
@mikeshelton1503 proposed the following mockups:
Page Redirects
Refactoring tasks
Create Edit Card Details skeleton that can be shared by loading placeholder and page component- it produced more lines of code, than using duplicated code in case of Edit Card Details page, let's skip it for the time beingThe text was updated successfully, but these errors were encountered: