Purchases: Update the cancellation confirmation screen for domains #4495

Tug · 2016-04-03T23:27:57Z

Reimplement the "confirm cancel puchase" form for domains on the client.
Previously the form was returned by the API and injected into Calypso.

Testing Instructions

git fetch -a && git checkout update/confirm-cancel
Purchase a .live domain from Calypso using the sandbox store
Go to http://calypso.localhost:3000/purchases
Find your domain purchase and click on it.
The Cancel Domain and Refund option should be displayed.
Click on it then click on Cancel Domain and Refund
Ensure you land on http://calypso.localhost:3000/purchases/{SITE_ID}/{PURCHASE_ID}/confirm-cancel-domain
Choose a reason for canceling your domain, check the checkbox (eventually enter a message in the textarea) and click on Cancel Domain.
Verify that you are redirected to http://calypso.localhost:3000/purchases and that the following success notice is displayed:
"[domain] was successfully cancelled and refunded."
Verify that the domain no longer appears in the list of purchases

Reviews

Product Review
Code Review

Tug · 2016-04-03T23:35:40Z

client/me/purchases/confirm-cancel-domain/style.scss

@@ -0,0 +1,25 @@
+.confirm-cancel-domain {
+	// the following is a hack so the dropdown selector is not cropped when it overflows its container


I haven't found a nice way to fix this issue yet. If we remove this line the dropdown is cropped as shown here

A simple solution would be to use a select element instead of the SelectDropdown component.

scruffian · 2016-04-04T14:05:52Z

client/me/purchases/controller.jsx

-			paths.confirmCancelPurchase(),
-			'Confirm Cancel Purchase'
+			paths.confirmCancelDomain(),
+			'Confirm Cancel Domain'


Can we use titles.confirmCancelDomain here?

We could yeah, is it clearer what information is sent to the analytic engine though?

I don't think we want to pass a translated string to recordPageView.

scruffian · 2016-04-04T15:10:09Z

I see this when I try to cancel a business plan:

Error: ConfirmCancelDomain.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.

drewblaisdell · 2016-04-04T16:43:16Z

client/me/purchases/confirm-cancel-domain/index.jsx

+			return false;
+		}
+
+		if ( [ 'other_host', 'transfer' ].indexOf( selectedReason.value ) >= 0 ) {


Super minor, but you could replace this clause and the tail return with

return [ 'other_host', 'transfer' ].indexOf( selectedReason.value ) === -1;

drewblaisdell · 2016-04-04T21:33:07Z

client/me/purchases/confirm-cancel-purchase/load-endpoint-form.js

-function loadEndpointForm( selectedPurchase, onSuccess ) {
-	const { id, productId } = selectedPurchase;
-
-	wpcom.getCancellationPageHTML( id, productId, ( error, response ) => {


We should remove this endpoint from wpcom-undocumented/lib/unpublished.js.

Tug · 2016-04-04T21:33:42Z

I believe I took care of most of your concerns.
Rebased after #4475 was merged so the business issue should have been taken care of

drewblaisdell · 2016-04-04T23:58:48Z

This works well, and the code looks good to me. I updated the commit history with a couple minor changes: CSS naming fixes, as well as removing Undocumented.prototype.getCancellationPageHTML. Make sure to fetch/reset locally so as not to wipe out these changes. :)

scruffian · 2016-04-05T08:09:38Z

This looks good. I noticed #4518 while testing, but we should fix that in a different PR.

LGTM 👍

Reimplement confirm cancel puchase form for domain on the client. Previously the form was returned by the API and injected into Calypso

…rm Cancel Domain

Edited the logic of `isCancellable( purchase )`. A purchase can have its `isCancellable` property set to `false` when a request to cancel have already been made for instance.

…irmation screen

…ases instead

Purchases: Update the cancellation confirmation screen for domains

Tug self-assigned this Apr 3, 2016

Tug added [Status] In Progress [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Apr 3, 2016

Tug added this to the Amber: Sprint milestone Apr 3, 2016

Tug reviewed Apr 3, 2016
View reviewed changes

Tug added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 4, 2016

scruffian reviewed Apr 4, 2016
View reviewed changes

scruffian force-pushed the update/confirm-cancel branch from 95c2397 to 69cb2de Compare April 4, 2016 15:44

drewblaisdell reviewed Apr 4, 2016
View reviewed changes

drewblaisdell added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 4, 2016

Tug force-pushed the update/confirm-cancel branch from c68f6fb to 62e8796 Compare April 4, 2016 21:31

drewblaisdell reviewed Apr 4, 2016
View reviewed changes

Tug added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Apr 4, 2016

drewblaisdell force-pushed the update/confirm-cancel branch 2 times, most recently from 9876823 to e49047b Compare April 4, 2016 23:34

scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 5, 2016

Tug added 8 commits April 5, 2016 09:10

Cancellations: update confirm cancel purchase

07c498b

Reimplement confirm cancel puchase form for domain on the client. Previously the form was returned by the API and injected into Calypso

Purchases: Edit analytic event metadata emitted when landing on Confi…

41fee8b

…rm Cancel Domain

Purchases: Hide the Cancel button when a purchase is not cancellable

002d45a

Edited the logic of `isCancellable( purchase )`. A purchase can have its `isCancellable` property set to `false` when a request to cancel have already been made for instance.

Purchases: Add safeguard for non domain product on cancel domain conf…

04cdd13

…irmation screen

Purchases: Add tests for isCancelable

cbb2b4a

Purchases: code cleanup in confirm-cancel-domain

179c611

Purchases: edit safeguard for non domain purchase, redirect to /purch…

e409aee

…ases instead

Purchases: use cancelAndRefundPurchase instead of using wpcom directly

373ac2b

scruffian force-pushed the update/confirm-cancel branch from e49047b to 373ac2b Compare April 5, 2016 08:10

scruffian merged commit c6d004e into master Apr 5, 2016

scruffian removed the [Status] Ready to Merge label Apr 5, 2016

Tug deleted the update/confirm-cancel branch April 5, 2016 09:07

fabianapsimoes mentioned this pull request Apr 5, 2016

Purchases: Add loading page skeleton for Single Purchase pages #275

Closed

12 tasks

scruffian added a commit that referenced this pull request Apr 5, 2016

Merge pull request #4495 from Automattic/update/confirm-cancel

14b4554

Purchases: Update the cancellation confirmation screen for domains

drewblaisdell mentioned this pull request Apr 6, 2016

Purchases: Remove isCancelable condition from lib/purchases #4542

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Purchases: Update the cancellation confirmation screen for domains #4495

Purchases: Update the cancellation confirmation screen for domains #4495

Tug commented Apr 3, 2016

Tug Apr 3, 2016

scruffian Apr 4, 2016

Tug Apr 4, 2016

drewblaisdell Apr 4, 2016

scruffian commented Apr 4, 2016

drewblaisdell Apr 4, 2016

drewblaisdell Apr 4, 2016

Tug commented Apr 4, 2016

drewblaisdell commented Apr 4, 2016

scruffian commented Apr 5, 2016

		@@ -0,0 +1,25 @@
		.confirm-cancel-domain {
		// the following is a hack so the dropdown selector is not cropped when it overflows its container

Purchases: Update the cancellation confirmation screen for domains #4495

Purchases: Update the cancellation confirmation screen for domains #4495

Conversation

Tug commented Apr 3, 2016

Testing Instructions

Reviews

Tug Apr 3, 2016

Choose a reason for hiding this comment

scruffian Apr 4, 2016

Choose a reason for hiding this comment

Tug Apr 4, 2016

Choose a reason for hiding this comment

drewblaisdell Apr 4, 2016

Choose a reason for hiding this comment

scruffian commented Apr 4, 2016

drewblaisdell Apr 4, 2016

Choose a reason for hiding this comment

drewblaisdell Apr 4, 2016

Choose a reason for hiding this comment

Tug commented Apr 4, 2016

drewblaisdell commented Apr 4, 2016

scruffian commented Apr 5, 2016