-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/shrinkwrap #12356
Update/shrinkwrap #12356
Conversation
Tested the reader and all seem to work as expected. cc @blowery for review, in case I missed something. |
This works well, though before we can merge it, could you help me understand why exactly did the tests break? Did they break after shrink-wrapping? |
This is going to be fun. Instructions to reproduce the bug:
Unfortunately, these instructions would have let you to reproduce the bug yesterday in the morning, but not today. More specifically, this bug is only reproducible if you did the shrinkwrap at any point between 2017-03-20 18:10 and 2017-03-21 10:39. Reason is: the source of error is an update in the A more detailed explanation:
|
0f4ee2d
to
98da5fe
Compare
Ah, forgot to mention: the tests no longer need fixing for the reason stated above, a mere shrinkwrap will suffice. Rebased the PR with the latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
While rebasing and shrinkwrapping an unrelated PR #6945 I found that two tests were failing. It seems that the cause is that
npm-shrinkwrap.json
is outdated inmaster
, so I prefer separate concerns and merge the other PR after this is solved.