-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using document
and window
global variables won't cover all cases
#156
Comments
Yup. If this is causing a problem in some Facebook project using fbjs, feel free to send a pull request. (If not, we don't have the time to support other uses of fbjs – sorry.) |
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Sep 28, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Sep 28, 2016
acusti
pushed a commit
to brandcast/fbjs
that referenced
this issue
Sep 28, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Sep 28, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Sep 28, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Oct 6, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Oct 6, 2016
acusti
pushed a commit
to brandcast/fbjs
that referenced
this issue
Oct 6, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Oct 6, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Oct 6, 2016
sophiebits
pushed a commit
that referenced
this issue
Oct 7, 2016
acusti
added a commit
to brandcast/fbjs
that referenced
this issue
Mar 16, 2017
* [fbjs] Use relative document and window (facebook#156) * [fbjs] Support nested browsing contexts (facebook#156) * [fbjs] Test getActiveElement api change (facebook#156)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I can see that we are replying to
window
anddocument
variables, that won't be great for some edge cases.For example on this instance:
https://github.com/facebook/fbjs/blob/master/src/__forks__/Style.js#L51
then
Style.getScrollParent
won't work on the following example:The text was updated successfully, but these errors were encountered: