-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Following Manage UI nits #13787
Conversation
To dos:
The following filter needs to display an error message as well just like it does currently:
/cc @samouri |
Lets keep this PR just to alignment issues. moving error handling to: #13834 |
@jancavan Also, can the carrot in the popover be aligned with the icon, not the text? Like so? |
|
247a57b
to
3df6d8f
Compare
d0f1689
to
dcfdf3d
Compare
Thanks @samouri. Happens in wide widths. it’s also tricky to correct it in Devdocs since we wrap it around a |
Before:
![screenshot 2017-05-08 21 46 56](https://cloud.githubusercontent.com/assets/4924246/25836090/ebeb549c-3438-11e7-9d9c-fde2e02fbea4.png)
After:
![screenshot 2017-05-08 21 47 27](https://cloud.githubusercontent.com/assets/4924246/25836093/f45a3c56-3438-11e7-8dc6-d21b6944319f.png)
Before:
![screenshot 2017-05-08 21 56 10](https://cloud.githubusercontent.com/assets/4924246/25836123/4d3735ae-3439-11e7-8196-84eea8b3a23d.png)
After:
![screenshot 2017-05-08 21 56 51](https://cloud.githubusercontent.com/assets/4924246/25836125/559b0400-3439-11e7-9dce-829827ea94ea.png)