Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Following Manage UI nits #13787

Merged
merged 14 commits into from
May 11, 2017
Merged

Reader: Following Manage UI nits #13787

merged 14 commits into from
May 11, 2017

Conversation

jancavan
Copy link
Contributor

@jancavan jancavan commented May 9, 2017

  • Fix alignment of Follow(ing) buttons:

Before:
screenshot 2017-05-08 21 46 56

After:
screenshot 2017-05-08 21 47 27

  • Fix white popover arrow

Before:
screenshot 2017-05-08 21 56 10

After:
screenshot 2017-05-08 21 56 51

  • Follow(ing) icons alignment
  • Limit Site Title, byline, and URL to a single line in Site Results

@jancavan jancavan added [Feature] Reader The reader site on Calypso. [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels May 9, 2017
@jancavan jancavan self-assigned this May 9, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] M Medium sized issue label May 9, 2017
@jancavan
Copy link
Contributor Author

jancavan commented May 9, 2017

To dos:

  • Add search term to error message: Sorry, no sites match _yourquery_.
  • Add error class to the search field

screenshot-2017-05-09-11 03 03

The following filter needs to display an error message as well just like it does currently:

  • Add search term to error message: Sorry, no followed sites match _yourquery_.
  • Add error class to the search field

screenshot-2017-05-09-10 54 39

/cc @samouri

@samouri
Copy link
Contributor

samouri commented May 9, 2017

Add search term to error message: Sorry, no sites match yourquery.

Lets keep this PR just to alignment issues. moving error handling to: #13834

@jancavan jancavan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 9, 2017
@jancavan jancavan requested review from fraying and samouri May 9, 2017 21:33
@fraying
Copy link
Contributor

fraying commented May 9, 2017

@jancavan Is this (#13433) possible?

8ea01ede-2a75-11e7-8fa7-a1f6545151d0

@fraying
Copy link
Contributor

fraying commented May 9, 2017

@jancavan Also, can the carrot in the popover be aligned with the icon, not the text? Like so?

settingspopover

@jancavan jancavan added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 10, 2017
@matticbot matticbot added [Size] L Large sized issue and removed [Size] M Medium sized issue labels May 10, 2017
@jancavan
Copy link
Contributor Author

Fixed #13433 in 55b654f.

Also, can the carrot in the popover be aligned with the icon, not the text? Like so?

The positioning is being generated dynamically, but @samouri is this possible?

@samouri
Copy link
Contributor

samouri commented May 10, 2017

The positioning is being generated dynamically, but @samouri is this possible?

done in 3affcf6 🥕

@jancavan
Copy link
Contributor Author

Thanks @samouri, that was clever 😄

Fixed #13433 in 55b654f.

This misaligned those without gravs/blavs. Taking a look at it again.

@jancavan
Copy link
Contributor Author

I don't know why I didn't think of this solution the last time, but #13433 is fixed in: e3beee8

screenshot 2017-05-10 12 21 40

@jancavan jancavan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 10, 2017
@samouri samouri added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 10, 2017
@samouri
Copy link
Contributor

samouri commented May 10, 2017

                 _-====-__-======-__-========-_____-============-__
               _(                                                 _)
            OO(              DEPLOY TRAIN                         )_
           0  (_                                                   _)
         o0     (_                                                _)
        o         '=-___-===-_____-========-___________-===-dwb-='
      .o                                _________
     . ______          ______________  |         |      _____
   _()_||__|| ________ |            |  |_________|   __||___||__
  (         | |      | |            | __Y______00_| |_         _|
 /-OO----OO""="OO--OO"="OO--------OO"="OO-------OO"="OO-------OO"=P
#####################################################################

@jancavan jancavan force-pushed the fix/reader/som-nits branch from 247a57b to 3df6d8f Compare May 11, 2017 01:51
@jancavan jancavan force-pushed the fix/reader/som-nits branch from d0f1689 to dcfdf3d Compare May 11, 2017 17:49
@jancavan jancavan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 11, 2017
@samouri
Copy link
Contributor

samouri commented May 11, 2017

seeing some weirdness still at small-medium widths like:

But that wasn't caused by this PR so 🚢

@samouri samouri added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 11, 2017
@jancavan
Copy link
Contributor Author

Thanks @samouri. Happens in wide widths. it’s also tricky to correct it in Devdocs since we wrap it around a card width paddings. We don't have those paddings in SoM.

@jancavan jancavan merged commit 85f76ef into master May 11, 2017
@jancavan jancavan deleted the fix/reader/som-nits branch May 11, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Size] L Large sized issue [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants