Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: Fix follow button alignment site search #14192

Merged
merged 3 commits into from
May 18, 2017
Merged

Reader: Fix follow button alignment site search #14192

merged 3 commits into from
May 18, 2017

Conversation

jancavan
Copy link
Contributor

Related: #13433 and #13787.

Follow button alignment in Site Search needs to match that of Following.

Before:
screenshot 2017-05-17 12 41 16

After:
screenshot 2017-05-17 12 41 48

@jancavan jancavan added [Feature] Reader The reader site on Calypso. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug When a feature is broken and / or not performing as intended labels May 17, 2017
@jancavan jancavan self-assigned this May 17, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/reader/follow-button-alignment-site-search-results

@matticbot matticbot added the [Size] S Small sized issue label May 17, 2017
bluefuton
bluefuton approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@bluefuton bluefuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bluefuton bluefuton added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 18, 2017
@jancavan jancavan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Ready to Merge labels May 18, 2017
@jancavan
Copy link
Contributor Author

@bluefuton this actually misaligned the Follow(ing) buttons in site recs so I scoped it to search results and your following list only.

@bluefuton
Copy link
Contributor

Sorry I missed the site rec alignment first time around. Looks good now 👍

@bluefuton bluefuton added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 18, 2017
@jancavan jancavan merged commit 63fd116 into master May 18, 2017
@jancavan jancavan deleted the fix/reader/follow-button-alignment-site-search-results branch May 18, 2017 19:58
@jancavan jancavan mentioned this pull request May 18, 2017
Closed
This was referenced May 30, 2021
Open
Open
This was referenced Oct 24, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Oct 20, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Oct 20, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 16, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Nov 17, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Mar 27, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluefuton bluefuton bluefuton approved these changes

Assignees

@jancavan jancavan

Labels
[Feature] Reader The reader site on Calypso. [Size] S Small sized issue [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Reader: Manage Following Refresh
Development

Successfully merging this pull request may close these issues.
3 participants
@jancavan @matticbot @bluefuton