Move Domain Connect Sync Flow from React PropTypes to prop-types #18046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delputnam
added
[Feature Group] Emails & Domains
delputnam
added
the
[Status] Needs Review
klimeryk
approved these changes
Sep 15, 2017
| @@ -1,7 +1,8 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| import React, { Component, PropTypes } from 'react'; | |||
| */ | |||
There was a problem hiding this comment.
OMG WHY DID YOU REMOVE THIS SPACE?!?!?!?!111 What does it all mean?
....
Seriously, though, probably best to keep it consistently formatted across files.
There was a problem hiding this comment.
Huh. I definitely didn't mean to do that. Will fix. Thanks!
klimeryk
added
[Status] Ready to Merge
and removed
[Status] Needs Review
delputnam
deleted the
janitorial/move-domain-connect-sync-flow-to-npm-prop-types
branch
This was referenced May 15, 2021
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just migrating the PropTypes from the React PropTypes to PropTypes from prop-types.
D5862-code (which is now merged), includes instructions on how to test the Domain Connect Sync Flow.