Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Domain Connect Sync Flow from React PropTypes to prop-types #18046

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Move Domain Connect Sync Flow from React PropTypes to prop-types #18046

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f03088b
Move from React PropTypes to prop-types
delputnam Sep 14, 2017
30e2a48
Added inadvertently removed space from comment block.
delputnam Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...y-sites/domains/domain-management/domain-connect/domain-connect-authorize-description.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* External dependencies
*/
import React, { Component, PropTypes } from 'react';
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { localize } from 'i18n-calypso';

class DomainConnectAuthorizeDescription extends Component {
Expand Down
3 changes: 2 additions & 1 deletion client/my-sites/domains/domain-management/domain-connect/domain-connect-authorize-footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* External dependencies
*/
import React, { Component, PropTypes } from 'react';
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { localize } from 'i18n-calypso';
import Gridicon from 'gridicons';

Expand Down
3 changes: 2 additions & 1 deletion ...nt/my-sites/domains/domain-management/domain-connect/domain-connect-authorize-records.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* External dependencies
*/
import React, { Component, PropTypes } from 'react';
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { localize } from 'i18n-calypso';

/**
Expand Down
5 changes: 3 additions & 2 deletions client/my-sites/domains/domain-management/domain-connect/domain-connect-authorize.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* External dependencies
*/
import React, { Component, PropTypes } from 'react';
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG WHY DID YOU REMOVE THIS SPACE?!?!?!?!111 What does it all mean?
....
:trollface:
Seriously, though, probably best to keep it consistently formatted across files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I definitely didn't mean to do that. Will fix. Thanks!

import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { localize } from 'i18n-calypso';

/**
Expand Down