add siteId as param to themeHasAutoLoadingHomepage

[andres-blanco]

Add the siteId param to themeHasAutoLoadingHomepage selector so we can check themes for the auto-loading-homepage tag whether on WPCOM or individual Atomic sites. The logic to check on Atomic sites is guarded behind the themes/atomic-homepage-replace so this PR has no visible change.

This is a PR that splits the work done in this other PR.

Testing

1. Apply this PR.
2. Go to the theme showcase on a Simple site and verify everything works as always when changing a theme; clicking 'Activate' and preserving or replacing site homepage.
3. Go to the theme showcase on an Atomic site and verify everything works as always when changing a theme; clicking 'Activate' should preserve the homepage.

Related to #56869

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-f55e7ef35084fe70f4b18616df9d969fac3a8fc4

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-f55e7ef35084fe70f4b18616df9d969fac3a8fc4&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~9 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +108 B  (+0.0%)       +9 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4628 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
theme          +461 B  (+0.1%)    +1154 B  (+0.8%)
checkout       +339 B  (+0.0%)     -231 B  (-0.1%)
themes         +265 B  (+0.0%)     -125 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[mreishus]

LGTM

• Found no changes for existing behavior (atomic, simple replace, simple keep). ✔️
• Tried with flag on but noticed that no themes I tried were returning atomicAutoLoading=true (probably expected).

I also noticed that about half the calls to themeHasAutoLoadingHomepage have themeId=undefined. I think they're coming from the modal when it isn't showing. Not something too important but something strange that I found while testing that I wanted to share.

[andres-blanco]

LGTM

• Found no changes for existing behavior (atomic, simple replace, simple keep). ✔️
• Tried with flag on but noticed that no themes I tried were returning atomicAutoLoading=true (probably expected).

I also noticed that about half the calls to themeHasAutoLoadingHomepage have themeId=undefined. I think they're coming from the modal when it isn't showing. Not something too important but something strange that I found while testing that I wanted to share.

nice catch about the themeId. I will keep that in mind. Thanks :)