Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Switch Modal: Option to select home page content from demo when switching missing from Atomic #56869

Closed
ianstewart opened this issue Oct 7, 2021 · 12 comments · Fixed by #66052
Assignees
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pod] Flow Patrol (Manage) [Pri] Normal [Status] In Progress Triaged To be used when issues have been triaged. [Type] Bug

Comments

@ianstewart
Copy link
Contributor

ianstewart commented Oct 7, 2021

This Modal does not currently appear for Recommended Themes on Atomic sites.

image

@Robertght Robertght added Triaged To be used when issues have been triaged. [Pod] Flow Patrol (Manage) labels Oct 8, 2021
@dpasque dpasque added Atomic [Feature Group] Appearance & Themes Features related to the appearance of sites. labels Oct 8, 2021
@sixhours
Copy link
Contributor

The absence of the theme-switch modal has to do with a lack of full Headstart support on Atomic sites (see #53233). That's a bigger project than Flow Patrol can take on in the span of one or two sprints (I believe we only have one full-length sprint after this one), but I don't want this to get lost in the shuffle.

@ianstewart Are there any teams/pods that will be focused on site creation that could add this to their board for further iteration?

@roo2 roo2 self-assigned this Feb 10, 2022
@roo2
Copy link
Contributor

roo2 commented Feb 10, 2022

As @sixhours said, it looks like there's a decent amount of effort required to get this working, I pinged you on a p2 to discus pbxlJb-WW-p2

@roo2
Copy link
Contributor

roo2 commented Feb 15, 2022

Summary of the P2 discussion: we will likely put this on pause until after changes to headstart related to verticalization pbxlJb-WW-p2#comment-1149. It does turn out that headstart is somwhat designed to be made portable pbxlJb-WW-p2#comment-1150, and we could possibly implement this homepage switcher without porting all of headstart pbxlJb-WW-p2#comment-1151, but there is still some technical complexity pbxlJb-WW-p2#comment-1149.

In summary, I don't think we will pick this up just yet.

@autumnfjeld
Copy link
Contributor

@cometgrrl What should we do with tickets like this, that we've concluded we won't address right now. Meaning does it sense to move them out of our Ganon column in https://github.com/orgs/Automattic/projects/343 ?

@cometgrrl
Copy link
Contributor

I'll make a new "on hold" column, and move it over. Also, since we are actively deciding not to work on it, I will lower the priority.

@jamiepalatnik
Copy link

A user was looking for this feature: 34556864-hc

@jp-imagines
Copy link

See #60875 for some more user requests for this feature.

Also encountered a request in 5290079-zd-woothemes; this user specifically stated that they were "so frustrated and not having a good experience with Wordpress[.com]," at least in part because switching themes was made more difficult without this feature (which they're used to seeing on simple sites).

@andres-blanco
Copy link
Contributor

I've made some progress on this: paYKcK-1Mb-p2

@andres-blanco andres-blanco self-assigned this Jun 21, 2022
@andres-blanco
Copy link
Contributor

Headstart dependency for this process was removed in D82671-code

@sbathompson-he
Copy link

This happened here as well. 36018297-hc
Lost the customer, but the Byrne theme does not offer this option. We had to manually import the content.

@andres-blanco
Copy link
Contributor

Fix deployed behind flag. See paYKcK-1Wj-p2 for more details.

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5290079-zen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment